You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@camel.apache.org by Trevv <45...@safe-mail.net> on 2008/11/25 09:37:33 UTC
MinaConsumer timeout?
I think the normal way to timeout an incoming Mina connection is to
implement org.apache.mina.common.IoHandler.sessionIdle. But I don't see
any good way to do this in Camel, because MinaConsumer$ReceiveHandler is
final and inherits a no-op implementation of sessionIdle.
I don't personally need sessionIdle, because I've decided that for
my current project the two-hour timeout provided by SO_KEEPALIVE is
good enough, and I found that I could easily enable SO_KEEPALIVE by
overriding MinaComponent.configureSocketCodecFactory.
I'm just writing to suggest that you might want to add MinaConsumer
timeouts to the agenda for Camel 2.0, because timeouts are very useful.
Or does Camel already have a way to do MinaConsumer timeouts, and I
just didn't notice it?
--
View this message in context: http://www.nabble.com/MinaConsumer-timeout--tp20677039s22882p20677039.html
Sent from the Camel - Users mailing list archive at Nabble.com.
Re: MinaConsumer timeout?
Posted by Trevv <45...@safe-mail.net>.
Claus Ibsen-2 wrote:
> Do you mind creating a ticket for this and if possible submitting a
> patch. Then as with the http heaaders I will be able to commit it in
> very short time.
This one will require more thought (e.g. about promoting ReceiveHandler
to be a non-inner class) so I'll think about it. It won't be very soon,
because I'm going to be out of town for a while.
--
View this message in context: http://www.nabble.com/MinaConsumer-timeout--tp20677039s22882p20757881.html
Sent from the Camel - Users mailing list archive at Nabble.com.
Re: MinaConsumer timeout?
Posted by Claus Ibsen <cl...@gmail.com>.
Hi Trev
Do you mind creating a ticket for this and if possible submitting a
patch. Then as with the http heaaders I will be able to commit it in
very short time.
/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/
On Tue, Nov 25, 2008 at 1:08 PM, Claus Ibsen <cl...@gmail.com> wrote:
> Hi Trew
>
> Well spotted, there is no timeout in the consumer.
> You are welcome to create a ticket in JIRA and if possible submit a
> patch with unittest (preferred to have test)
>
> /Claus Ibsen
> Apache Camel Committer
> Blog: http://davsclaus.blogspot.com/
>
>
>
> On Tue, Nov 25, 2008 at 9:37 AM, Trevv <45...@safe-mail.net> wrote:
>>
>> I think the normal way to timeout an incoming Mina connection is to
>> implement org.apache.mina.common.IoHandler.sessionIdle. But I don't see
>> any good way to do this in Camel, because MinaConsumer$ReceiveHandler is
>> final and inherits a no-op implementation of sessionIdle.
>>
>> I don't personally need sessionIdle, because I've decided that for
>> my current project the two-hour timeout provided by SO_KEEPALIVE is
>> good enough, and I found that I could easily enable SO_KEEPALIVE by
>> overriding MinaComponent.configureSocketCodecFactory.
>>
>> I'm just writing to suggest that you might want to add MinaConsumer
>> timeouts to the agenda for Camel 2.0, because timeouts are very useful.
>>
>> Or does Camel already have a way to do MinaConsumer timeouts, and I
>> just didn't notice it?
>> --
>> View this message in context: http://www.nabble.com/MinaConsumer-timeout--tp20677039s22882p20677039.html
>> Sent from the Camel - Users mailing list archive at Nabble.com.
>>
>>
>
Re: MinaConsumer timeout?
Posted by Claus Ibsen <cl...@gmail.com>.
Hi Trew
Well spotted, there is no timeout in the consumer.
You are welcome to create a ticket in JIRA and if possible submit a
patch with unittest (preferred to have test)
/Claus Ibsen
Apache Camel Committer
Blog: http://davsclaus.blogspot.com/
On Tue, Nov 25, 2008 at 9:37 AM, Trevv <45...@safe-mail.net> wrote:
>
> I think the normal way to timeout an incoming Mina connection is to
> implement org.apache.mina.common.IoHandler.sessionIdle. But I don't see
> any good way to do this in Camel, because MinaConsumer$ReceiveHandler is
> final and inherits a no-op implementation of sessionIdle.
>
> I don't personally need sessionIdle, because I've decided that for
> my current project the two-hour timeout provided by SO_KEEPALIVE is
> good enough, and I found that I could easily enable SO_KEEPALIVE by
> overriding MinaComponent.configureSocketCodecFactory.
>
> I'm just writing to suggest that you might want to add MinaConsumer
> timeouts to the agenda for Camel 2.0, because timeouts are very useful.
>
> Or does Camel already have a way to do MinaConsumer timeouts, and I
> just didn't notice it?
> --
> View this message in context: http://www.nabble.com/MinaConsumer-timeout--tp20677039s22882p20677039.html
> Sent from the Camel - Users mailing list archive at Nabble.com.
>
>