[jira] [Comment Edited] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

["Chunwei Lei (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840276#comment-16840276 ] 

Chunwei Lei edited comment on CALCITE-3050 at 5/15/19 10:20 AM:
----------------------------------------------------------------

[~julianhyde], [~danny0405]

the PR looks good and I left some comments on github.;)


was (Author: chunwei lei):
[~julianhyde], the PR looks good and I left some comments on github.

> Integrate SqlDialect and SqlParser.Config
> -----------------------------------------
>
>                 Key: CALCITE-3050
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3050
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Danny Chan
>            Priority: Major
>
> {{SqlDialect}} is used by the JDBC adapter to generate SQL in the target dialect of a data source. {{SqlParser.Config}} is used to set what the parser should allow for SQL statements sent to Calcite. But they both are a representation of "dialect". And they come together when we want to use a Babel parser to understand SQL statements that are meant for a data source.
> So it makes sense to integrate them, somehow. We could add a method {code}void SqlParser.ConfigBuilder.setFrom(SqlDialect dialect){code} or do it from the other end, {code}SqlDialect.configureParser(SqlParser.ConfigBuilder configBuilder){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)