[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #6731: [Improvement][Log] optimize task log path to reduce task running time

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #6731:
URL: https://github.com/apache/dolphinscheduler/pull/6731#discussion_r744878167



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/DateUtils.java
##########
@@ -506,6 +506,16 @@ public static TimeZone getTimezone(String timezoneId) {
         return TimeZone.getTimeZone(timezoneId);
     }
 
+    /**
+     * get specify date
+     */
+    public static Date getSpecifyDate(int year, int month, int date) {

Review comment:
       Please, this method is only for test, it's not necessary to add this method to increase maintainers' burden, please just move it into the test.

##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
##########
@@ -258,6 +258,14 @@ private Constants() {
     public static final String YYYY_MM_DD_HH_MM_SS = "yyyy-MM-dd HH:mm:ss";
 
 
+

Review comment:
       Remove the extra blank lines and only keep one blank line.
   
   BTW, @zhongjiajie can you please set up a code style rule to only allow at most one blank line between member fields / methods?

##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java
##########
@@ -258,6 +258,14 @@ private Constants() {
     public static final String YYYY_MM_DD_HH_MM_SS = "yyyy-MM-dd HH:mm:ss";
 
 
+
+    /**
+     * date format of yyyyMMdd
+     */
+    public static final String YYYYMMDD = "yyyyMMdd";
+
+
+

Review comment:
       Remove the extra blank lines and only keep one blank line




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org