You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "gustavodemorais (via GitHub)" <gi...@apache.org> on 2025/02/26 15:59:19 UTC
[PR] [hotfix] Rename SparkJoinReorderRule to FlinkJoinReorderRule [flink]
gustavodemorais opened a new pull request, #26218:
URL: https://github.com/apache/flink/pull/26218
Creates a FlinkJoinReorderRule and not SparkJoinReorderRule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Rename SparkJoinReorderRule to FlinkJoinReorderRule [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26218:
URL: https://github.com/apache/flink/pull/26218#issuecomment-2685565571
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bb1dd300ac2d83d83326db4a551ee49bd8e0342",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9bb1dd300ac2d83d83326db4a551ee49bd8e0342",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bb1dd300ac2d83d83326db4a551ee49bd8e0342 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Rename SparkJoinReorderRule to FlinkJoinReorderRule [flink]
Posted by "gustavodemorais (via GitHub)" <gi...@apache.org>.
gustavodemorais commented on code in PR #26218:
URL: https://github.com/apache/flink/pull/26218#discussion_r1971983401
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinReorderRule.java:
##########
@@ -54,7 +54,7 @@ public class FlinkJoinReorderRule extends RelRule<FlinkJoinReorderRule.Config>
private static final FlinkBushyJoinReorderRule BUSHY_JOIN_REORDER =
FlinkBushyJoinReorderRule.Config.DEFAULT.toRule();
- /** Creates an SparkJoinReorderRule. */
+ /** Creates an FlinkJoinReorderRule. */
Review Comment:
Yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Rename SparkJoinReorderRule to FlinkJoinReorderRule [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #26218:
URL: https://github.com/apache/flink/pull/26218#discussion_r1971909768
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkJoinReorderRule.java:
##########
@@ -54,7 +54,7 @@ public class FlinkJoinReorderRule extends RelRule<FlinkJoinReorderRule.Config>
private static final FlinkBushyJoinReorderRule BUSHY_JOIN_REORDER =
FlinkBushyJoinReorderRule.Config.DEFAULT.toRule();
- /** Creates an SparkJoinReorderRule. */
+ /** Creates an FlinkJoinReorderRule. */
Review Comment:
```suggestion
/** Creates a FlinkJoinReorderRule. */
```
should it be just `a`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Rename SparkJoinReorderRule to FlinkJoinReorderRule [flink]
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys merged PR #26218:
URL: https://github.com/apache/flink/pull/26218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org