[GitHub] [pulsar-client-go] taiyang-li commented on issue #228: ClientOptions should get a Logger field to allow injecting of an external Logger

[GitBox <gi...@apache.org>]

taiyang-li commented on issue #228:
URL: https://github.com/apache/pulsar-client-go/issues/228#issuecomment-656462219


   Pulsar-client-go use default logger `std` allaround. 
   
   In most cases, this will work , because users are able to `SetOutput`  `SetFormatter`  `SetLevel`  (refer to https://github.com/sirupsen/logrus/blob/master/exported.go)  
   
   But if users already use default logrus logger `std` before introduce the dependency of pulsar-client-go,  and they want to set different output/formatter/level for these 2 cases,  there would be a problem.
   
   So I think it is better to use a  diffrent default logrus logger(not `std`) for pulsar-go-client, which will provide much more flexibility of logging for users
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org