You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/10/25 00:16:21 UTC

[GitHub] [incubator-mxnet] ptrendx commented on issue #16615: Faster general take

ptrendx commented on issue #16615: Faster general take
URL: https://github.com/apache/incubator-mxnet/pull/16615#issuecomment-546150156
 
 
   Few questions:
   - Can we rename the `TakeCPU/TakeGPU` to something like `TakeZeroAxisCPU`/`TakeZeroAxisGPU` and Take to `TakeNonzeroAxis`?
   - Are there any other functions that use `Take` that could be affected by it not supporting `axis=0` anymore? 
   - Also, could you explain what makes your version faster? Is it just replacing taking values from array with actual values? If so, I wonder whether the problem does not just come from the fact that the `Shape<10>` is passed to the function by value instead of by const reference `const Shape<10>&`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services