You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/12/23 09:13:38 UTC

[GitHub] [apisix] starsz opened a new issue #5900: request help: support hide the authentication header in basic-auth and key-auth plugins

starsz opened a new issue #5900:
URL: https://github.com/apache/apisix/issues/5900


   ### Issue description
   
   Hello,
   When using base-auth plugins, I don't want to pass the `Authentication` header to upstream.
   IMO, there is no need for upstream to perceive these authentication headers.
   
   Now, I use `proxy-rewrite` plugin to rewrite the `Authentication` head like this:
   
   ```
    "plugins": {
           "basic-auth": {},
           "proxy-rewrite": {
               "headers": {
                   "Authorization": ""
               }
           }
       },
   ```
   
   I think we can add a config in the `basic-auth` plugin to hide the auth head.
   That will be more convenient in using these plugins. So do `key-auth` plugin.
   
   ### Environment
   
   - apisix version (cmd: `apisix version`): 2.11.0
   - OS (cmd: `uname -a`): 
   - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   - apisix-dashboard version, if have:
   - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner):
   - luarocks version, if the issue is about installation (cmd: `luarocks --version`):
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] tokers commented on issue #5900: request help: support hide the authentication header in basic-auth and key-auth plugins

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #5900:
URL: https://github.com/apache/apisix/issues/5900#issuecomment-1000177380


   Agress +1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] tokers commented on issue #5900: request help: support hide the authentication header in basic-auth and key-auth plugins

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #5900:
URL: https://github.com/apache/apisix/issues/5900#issuecomment-1000604082


   > useful, maybe *-auth plugins are all needed
   
   Exactly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on issue #5900: request help: support hide the authentication header in basic-auth and key-auth plugins

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #5900:
URL: https://github.com/apache/apisix/issues/5900#issuecomment-1000708181


   > useful, maybe *-auth plugins are all needed
   
   I don't think blindly applying this to other *-auth plugins is a good idea. Take jwt-auth as an example, the JWT token serves both as a user id and storage containing user info. We should discuss it plugin by plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander closed issue #5900: request help: support hide the authentication header in basic-auth and key-auth plugins

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #5900:
URL: https://github.com/apache/apisix/issues/5900


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] tzssangglass commented on issue #5900: request help: support hide the authentication header in basic-auth and key-auth plugins

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #5900:
URL: https://github.com/apache/apisix/issues/5900#issuecomment-1000190196


   useful, maybe *-auth plugins are all needed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org