[GitHub] [iceberg] rdblue commented on a diff in pull request #4806: Fix invalid Stream to Iterable conversion in decryption

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4806:
URL: https://github.com/apache/iceberg/pull/4806#discussion_r884323420


##########
api/src/main/java/org/apache/iceberg/encryption/EncryptionManager.java:
##########
@@ -47,11 +49,26 @@ public interface EncryptionManager extends Serializable {
    * By default this calls the single-file decryption method for each element in the iterator.
    * Implementations can override this for a variety of optimizations. For example, an
    * implementation can perform lookahead on the input iterator and fetch encryption keys in batch.
+   *
+   * @deprecated Use {@link #decrypt(Iterator)}.
    */
+  @Deprecated

Review Comment:
   This is a public API. We shouldn't make changes to a public API just because it is being called incorrectly in some places.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org