You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Jongyoul Lee <jo...@gmail.com> on 2018/08/21 06:57:28 UTC
[DISCUSS] Adopt google-java-format
Hi devs,
We are using checkstyle and its maven plugin to check style. It looks
reasonable but I got a checkstyle violation since it's different from
IntelliJ's formatter setting of formatting lambda function.
Thus, how about adopting google-java-format in your IDE and its maven
plugin to fix formatter issues?
See https://github.com/google/google-java-format and
https://github.com/coveo/fmt-maven-plugin
It's, strictly, not a checker, but formatter as it changes wrong formats
when building it.
WDYT?
--
이종열, Jongyoul Lee, 李宗烈
http://madeng.net
Re: [DISCUSS] Adopt google-java-format
Posted by Jongyoul Lee <jo...@gmail.com>.
Thanks.
I actually adopted it but revert it because of huge PRs :-). I'll adopt
it step by step again.
On Sat, Sep 8, 2018 at 5:08 PM, Alex Ott <al...@gmail.com> wrote:
> I personally think that this is great idea! I constantly hit by checkstyle
> :-)
>
> Jongyoul Lee at "Tue, 21 Aug 2018 15:57:28 +0900" wrote:
> JL> Hi devs,
>
> JL> We are using checkstyle and its maven plugin to check style. It looks
> JL> reasonable but I got a checkstyle violation since it's different from
> JL> IntelliJ's formatter setting of formatting lambda function.
>
> JL> Thus, how about adopting google-java-format in your IDE and its maven
> JL> plugin to fix formatter issues?
>
> JL> See https://github.com/google/google-java-format and
> JL> https://github.com/coveo/fmt-maven-plugin
>
> JL> It's, strictly, not a checker, but formatter as it changes wrong
> formats
> JL> when building it.
>
> JL> WDYT?
>
>
>
> --
> With best wishes, Alex Ott
> http://alexott.blogspot.com/ http://alexott.net/
> http://alexott-ru.blogspot.com/
> Skype: alex.ott
>
--
이종열, Jongyoul Lee, 李宗烈
http://madeng.net
Re: [DISCUSS] Adopt google-java-format
Posted by Alex Ott <al...@gmail.com>.
I personally think that this is great idea! I constantly hit by checkstyle :-)
Jongyoul Lee at "Tue, 21 Aug 2018 15:57:28 +0900" wrote:
JL> Hi devs,
JL> We are using checkstyle and its maven plugin to check style. It looks
JL> reasonable but I got a checkstyle violation since it's different from
JL> IntelliJ's formatter setting of formatting lambda function.
JL> Thus, how about adopting google-java-format in your IDE and its maven
JL> plugin to fix formatter issues?
JL> See https://github.com/google/google-java-format and
JL> https://github.com/coveo/fmt-maven-plugin
JL> It's, strictly, not a checker, but formatter as it changes wrong formats
JL> when building it.
JL> WDYT?
--
With best wishes, Alex Ott
http://alexott.blogspot.com/ http://alexott.net/
http://alexott-ru.blogspot.com/
Skype: alex.ott