You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/08/09 12:41:18 UTC
[GitHub] [incubator-devlake] Pranshu-Raj commented on a diff in pull request #2562: perf: added error handling missing code
Pranshu-Raj commented on code in PR #2562:
URL: https://github.com/apache/incubator-devlake/pull/2562#discussion_r941289733
##########
plugins/tapd/api/connection.go:
##########
@@ -161,5 +161,8 @@ GET /plugins/tapd/connections/:connectionId
func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error) {
connection := &models.TapdConnection{}
err := connectionHelper.First(connection, input.Params)
- return &core.ApiResourceOutput{Body: connection}, err
+ if err != nil {
+ return nil,err
+ }
+ return &core.ApiResourceOutput{Body: connection},nil
Review Comment:
sorry @klesh I am unable to resolve this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org