You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "zyfjrx (via GitHub)" <gi...@apache.org> on 2023/06/01 03:26:36 UTC
[GitHub] [dolphinscheduler] zyfjrx opened a new pull request, #14252: [Bug] [Seatunnel] Run Mode defaults to run, and you cannot select a n…
zyfjrx opened a new pull request, #14252:
URL: https://github.com/apache/dolphinscheduler/pull/14252
…ull value
https://github.com/apache/dolphinscheduler/issues/14250
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
When Dolphinscheduler creates a seattunnel task, if the Flink startup script is used, the Run Mode defaults to run, and a null value cannot be selected. As a result of this operation, when seatunnel invokes the Flink service to perform tasks, --run-mode run will be spliced by default in the execution command, but the run-mode parameter is not supported in multiple flink versions (tested 1.13 1.14 1.15 1.16 1.17), and finally Task execution failed.
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zyfjrx closed pull request #14252: [Bug] [Seatunnel] Run Mode defaults to run, and you cannot select a n…
Posted by "zyfjrx (via GitHub)" <gi...@apache.org>.
zyfjrx closed pull request #14252: [Bug] [Seatunnel] Run Mode defaults to run, and you cannot select a n…
URL: https://github.com/apache/dolphinscheduler/pull/14252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] rickchengx commented on pull request #14252: [Bug] [Seatunnel] Run Mode defaults to run, and you cannot select a n…
Posted by "rickchengx (via GitHub)" <gi...@apache.org>.
rickchengx commented on PR #14252:
URL: https://github.com/apache/dolphinscheduler/pull/14252#issuecomment-1573169387
> @rickchengx do i need to resubmit PR？
you just need to push again to your branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zyfjrx commented on pull request #14252: [Bug] [Seatunnel] Run Mode defaults to run, and you cannot select a n…
Posted by "zyfjrx (via GitHub)" <gi...@apache.org>.
zyfjrx commented on PR #14252:
URL: https://github.com/apache/dolphinscheduler/pull/14252#issuecomment-1573093313
@rickchengx do i need to resubmit PR？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] rickchengx commented on pull request #14252: [Bug] [Seatunnel] Run Mode defaults to run, and you cannot select a n…
Posted by "rickchengx (via GitHub)" <gi...@apache.org>.
rickchengx commented on PR #14252:
URL: https://github.com/apache/dolphinscheduler/pull/14252#issuecomment-1571448733
@zyfjrx please Run 'mvn spotless:apply' before your commit to fix style check errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org