[GitHub] SirIntellegence commented on a change in pull request #403: [NETBEANS-320] Mac modal dialogs pop-under non-modal dialogs

[GitBox <gi...@apache.org>]

SirIntellegence commented on a change in pull request #403: [NETBEANS-320] Mac modal dialogs pop-under non-modal dialogs
URL: https://github.com/apache/incubator-netbeans/pull/403#discussion_r172556072
 
 

 ##########
 File path: progress.ui/src/org/netbeans/modules/progress/ui/StatusLineComponent.java
 ##########
 @@ -502,7 +503,18 @@ private void removeListItem(InternalHandle handle) {
         // 2. on mac, needs an owner frame otherwise hiding tooltip also hides the popup. (linux requires no owner frame to force heavyweight)
         // 3. the created window is not focusable window
         if (popupWindow == null) {
-            popupWindow = new JWindow(WindowManager.getDefault().getMainWindow());
+            class ProgressPopUpWindow extends JWindow implements Leafable{
+                ProgressPopUpWindow(Frame parent) {
+                    super(parent);
+                }
+                @Override
+                public boolean isLeaf() {
+                    //never a parent
+                    return true;
+                }
+            }
+            popupWindow = new ProgressPopUpWindow(WindowManager.getDefault().
+                    getMainWindow());
 
 Review comment:
   True, but, as far as I know, `DialogDisplayer` doesn't have a way to request an un-decorated window or a JWindow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists