[GitHub] [helix] narendly commented on issue #819: Make RealmAwareZkClient implementations use HttpRoutingDataReader for routing data

[GitBox <gi...@apache.org>]

narendly commented on issue #819: Make RealmAwareZkClient implementations use HttpRoutingDataReader for routing data
URL: https://github.com/apache/helix/pull/819#issuecomment-594378577
 
 
   This PR is ready to be merged, approved by @pkuwm 
   
   We want all implementations of RealmAwareZkClient to do a one-time query to Metadata Store Directory Service for routing data and cache it in memory. In order to accomplish that, we have introduced HttpRoutingDataReader, which is a Singleton class that makes a REST call to read routing data and caches it in memory. This diff updates the initialization logic in RealmAwareZkClients accordingly.
   Changelist:
   
   Update all RealmAwareZkClient initialization logic
   Fix tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org