You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Jeff Trawick <tr...@gmail.com> on 2007/01/24 15:44:22 UTC

[BUG?] apr_proc_other_child_refresh passes wrong status flavor to maintenance function

In this code, a Unix-style signum|exitcode|bits is passed to the
maintenance function from within apr_proc_other_child_refresh().

    waitret = waitpid(ocr->proc->pid, &status, WNOHANG);
    if (waitret == ocr->proc->pid) {
        ocr->proc = NULL;
        (*ocr->maintenance) (APR_OC_REASON_DEATH, ocr->data, status);
    }

But for other calls to the maintenance function with
APR_OC_REASON_DEATH we expect that a signum_or_exitcode is passed to
the maintenance function (API breakage mentioned separately via
http://svn.apache.org/viewvc?view=rev&revision=499417).  It doesn't
make sense to pass a Unix-style status here.

Thoughts?