[GitHub] [incubator-inlong] kipshi commented on a change in pull request #2709: [INLONG-2693][Manager] Define tables and beans for getSortSource interface

[GitBox <gi...@apache.org>]

kipshi commented on a change in pull request #2709:
URL: https://github.com/apache/incubator-inlong/pull/2709#discussion_r815558869



##########
File path: inlong-manager/manager-web/sql/apache_inlong_manager.sql
##########
@@ -1123,6 +1123,52 @@ CREATE TABLE `sort_task_sink_param`
 ) ENGINE = InnoDB
   DEFAULT CHARSET = utf8mb4 COMMENT ='Sort task sink params table';
 
+-- ----------------------------
+-- Table structure for sort_source_config
+-- ----------------------------
+DROP TABLE IF EXISTS `sort_source_config`;
+CREATE TABLE `sort_source_config`
+(
+    `id`            int(11)       NOT NULL AUTO_INCREMENT COMMENT 'Incremental primary key',
+    `cluster_name`  varchar(128)  NOT NULL COMMENT 'Cluster name',
+    `task_name`     varchar(128)  NOT NULL COMMENT 'Task name',
+    `zone_name`     varchar(128)  NOT NULL COMMENT 'Cache zone name',
+    PRIMARY KEY (`id`),
+    KEY `index_sort_source_config` (`cluster_name`, `task_name`)
+) ENGINE = InnoDB
+  DEFAULT CHARSET = utf8mb4 COMMENT ='Sort source config table';

Review comment:
       All three tables cannot be designed as one table? If you need to design more abstract and reasonable than simple CRUD .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org