You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/02 16:26:43 UTC
[GitHub] [airflow] XD-DENG opened a new pull request #8071: Housekeeping of
auth backend & Update Security doc
XD-DENG opened a new pull request #8071: Housekeeping of auth backend & Update Security doc
URL: https://github.com/apache/airflow/pull/8071
- All authentication backends in `airflow/contrib/auth` are base on the `user` model which has already been removed earlier (https://github.com/apache/airflow/pull/4577)
- Security related documentation is out-dated, especially the LDAP and OAuth integration sections. It still directs user to the configuration of "old" web UI which has already been removed in master branch, while we should refer to the FAB doc instead.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8071: Housekeeping of auth
backend & Update Security doc
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8071: Housekeeping of auth backend & Update Security doc
URL: https://github.com/apache/airflow/pull/8071#issuecomment-608348741
Is the code really out-dated :)? I did not realise that :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] XD-DENG commented on issue #8071: Housekeeping of auth
backend & Update Security doc
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on issue #8071: Housekeeping of auth backend & Update Security doc
URL: https://github.com/apache/airflow/pull/8071#issuecomment-607952261
Hi @kaxil @potiuk @zhongjiajie , this is the change I mentioned in our earlier discussion https://github.com/apache/airflow/pull/4577#issuecomment-607066594 .
I will raise another PR to address similar issue (out-dated documentation) for 1-10-x branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] XD-DENG commented on issue #8071: Housekeeping of auth
backend & Update Security doc
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on issue #8071: Housekeeping of auth backend & Update Security doc
URL: https://github.com/apache/airflow/pull/8071#issuecomment-608361143
@potiuk It will be great if you can help take another further look and confirm.
The main reasoning is all of the `contrib/auth` backends are based on `models.User`, while `models.User` is already removed. But yes let's be careful about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] XD-DENG merged pull request #8071: Housekeeping of auth
backend & Update Security doc
Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #8071: Housekeeping of auth backend & Update Security doc
URL: https://github.com/apache/airflow/pull/8071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services