You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/20 12:32:48 UTC

[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #4826: Nessie: Use unique path for different table with same name

ajantha-bhat commented on code in PR #4826:
URL: https://github.com/apache/iceberg/pull/4826#discussion_r878095534


##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -157,19 +161,27 @@ public TableBuilder withProperty(String key, String value) {
       return this;
     }
 
+    public TableMetadata newTableMetadata() {

Review Comment:
   Extracting the logic that needs to be overridden for Nessie. 
   
   Without changing this class, need to copy-paste a lot of code from here to NessieCatalog for overriding. So, code duplication will be more.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org