You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/24 19:03:46 UTC

[GitHub] sijie closed pull request #1008: BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper

sijie closed pull request #1008: BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper
URL: https://github.com/apache/bookkeeper/pull/1008
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/site/bps/BP-25-MovingChecksumToProto.md b/site/bps/BP-25-MovingChecksumToProto.md
new file mode 100644
index 000000000..09f50196e
--- /dev/null
+++ b/site/bps/BP-25-MovingChecksumToProto.md
@@ -0,0 +1,27 @@
+---
+title: "BP-25: MovingChecksumToProto--Refactor the checksum part of bookkeeper"
+issue: https://github.com/apache/bookkeeper/issues/1007
+state: "Accepted"
+release: "N/A"
+---
+
+### Motivation
+
+Current the checksum implementation is in client module while the checksum semantic is more close to protocol. Moreover, moving the checksum implementation to protocol will avoid server module's dependency to client module when doing checksum in server side.
+
+### Public Interfaces
+
+An internal refactor not affecting public interfaces.
+
+### Proposed Changes
+
+Move the DigestManager and related classes to proto module
+
+### Compatibility, Deprecation, and Migration Plan
+N/A
+
+### Test Plan
+The original all tests should work as before.
+
+### Rejected Alternatives
+N/A
\ No newline at end of file
diff --git a/site/community/bookkeeper_proposals.md b/site/community/bookkeeper_proposals.md
index a918f9a9a..2802c652d 100644
--- a/site/community/bookkeeper_proposals.md
+++ b/site/community/bookkeeper_proposals.md
@@ -85,7 +85,7 @@ using Google Doc.
 
 This section lists all the _bookkeeper proposals_ made to BookKeeper.
 
-*Next Proposal Number: 23*
+*Next Proposal Number: 26*
 
 ### Inprogress
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services