You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Yonik Seeley <yo...@lucidimagination.com> on 2011/03/17 16:21:40 UTC

Re: svn commit: r1082520 - in /lucene/dev/trunk/solr/lib: servlet-api-LICENSE-ASL.txt servlet-api-LICENSE-SUN.txt servlet-api-NOTICE.txt

On Thu, Mar 17, 2011 at 11:05 AM,  <gs...@apache.org> wrote:
> Added: lucene/dev/trunk/solr/lib/servlet-api-NOTICE.txt
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/lib/servlet-api-NOTICE.txt?rev=1082520&view=auto
> ==============================================================================
> --- lucene/dev/trunk/solr/lib/servlet-api-NOTICE.txt (added)
> +++ lucene/dev/trunk/solr/lib/servlet-api-NOTICE.txt Thu Mar 17 15:05:44 2011
> @@ -0,0 +1,5 @@
> +Apache Tomcat
> +Copyright 1999-2007 The Apache Software Foundation
> +
> +This product includes software developed by
> +The Apache Software Foundation (http://www.apache.org/).

Why the NOTICE file here?
Hopefully this won't be used to automatically generate the NOTICE file for Solr?
I guess it's fine to keep just to document that there were no
additional required notices due to the jar, but we shouldn't throw it
all in our NOTICE file.

-Yonik
http://lucidimagination.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: svn commit: r1082520 - in /lucene/dev/trunk/solr/lib: servlet-api-LICENSE-ASL.txt servlet-api-LICENSE-SUN.txt servlet-api-NOTICE.txt

Posted by Yonik Seeley <yo...@lucidimagination.com>.
On Thu, Mar 17, 2011 at 11:30 AM, Grant Ingersoll <gs...@apache.org> wrote:
> If its ASL, it requires a NOTICE, is my understanding.

That's for a complete distribution, not every component of a distribution.
The NOTICE file is only for components which require special
attribution (so by some people's standards, we already include too
much info in NOTICE).  Our use of Tomcat does not, and best practice
seems to be to only put required attributions in NOTICE.

-Yonik
http://lucidimagination.com



  Some of these are admittedly redundant/overkill since we have a ton
of ASF code in here, but I'd like to keep a 1-1 for every jar, that
way we know what every JAR is and whether it requires one (see for
instance all the commons jars).  From that, we can then make a
decision about what belongs in the official LICENSE and NOTICE files.
 Also, the dependency checker code just does 1-1 checks on each jar,
so if it is ASL it expects a NOTICE to be alongside it.
>
> As for auto-generating, I think we will be able to de-dup before generating so it shouldn't be a problem.  I haven't written any code to auto-gen it yet, so it is still a manual process.
>
> -Grant
>
> On Mar 17, 2011, at 11:21 AM, Yonik Seeley wrote:
>
>> On Thu, Mar 17, 2011 at 11:05 AM,  <gs...@apache.org> wrote:
>>> Added: lucene/dev/trunk/solr/lib/servlet-api-NOTICE.txt
>>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/lib/servlet-api-NOTICE.txt?rev=1082520&view=auto
>>> ==============================================================================
>>> --- lucene/dev/trunk/solr/lib/servlet-api-NOTICE.txt (added)
>>> +++ lucene/dev/trunk/solr/lib/servlet-api-NOTICE.txt Thu Mar 17 15:05:44 2011
>>> @@ -0,0 +1,5 @@
>>> +Apache Tomcat
>>> +Copyright 1999-2007 The Apache Software Foundation
>>> +
>>> +This product includes software developed by
>>> +The Apache Software Foundation (http://www.apache.org/).
>>
>> Why the NOTICE file here?
>> Hopefully this won't be used to automatically generate the NOTICE file for Solr?
>> I guess it's fine to keep just to document that there were no
>> additional required notices due to the jar, but we shouldn't throw it
>> all in our NOTICE file.
>>
>> -Yonik
>> http://lucidimagination.com
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: svn commit: r1082520 - in /lucene/dev/trunk/solr/lib: servlet-api-LICENSE-ASL.txt servlet-api-LICENSE-SUN.txt servlet-api-NOTICE.txt

Posted by Grant Ingersoll <gs...@apache.org>.
If its ASL, it requires a NOTICE, is my understanding.  Some of these are admittedly redundant/overkill since we have a ton of ASF code in here, but I'd like to keep a 1-1 for every jar, that way we know what every JAR is and whether it requires one (see for instance all the commons jars).  From that, we can then make a decision about what belongs in the official LICENSE and NOTICE files.   Also, the dependency checker code just does 1-1 checks on each jar, so if it is ASL it expects a NOTICE to be alongside it.

As for auto-generating, I think we will be able to de-dup before generating so it shouldn't be a problem.  I haven't written any code to auto-gen it yet, so it is still a manual process.

-Grant

On Mar 17, 2011, at 11:21 AM, Yonik Seeley wrote:

> On Thu, Mar 17, 2011 at 11:05 AM,  <gs...@apache.org> wrote:
>> Added: lucene/dev/trunk/solr/lib/servlet-api-NOTICE.txt
>> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/lib/servlet-api-NOTICE.txt?rev=1082520&view=auto
>> ==============================================================================
>> --- lucene/dev/trunk/solr/lib/servlet-api-NOTICE.txt (added)
>> +++ lucene/dev/trunk/solr/lib/servlet-api-NOTICE.txt Thu Mar 17 15:05:44 2011
>> @@ -0,0 +1,5 @@
>> +Apache Tomcat
>> +Copyright 1999-2007 The Apache Software Foundation
>> +
>> +This product includes software developed by
>> +The Apache Software Foundation (http://www.apache.org/).
> 
> Why the NOTICE file here?
> Hopefully this won't be used to automatically generate the NOTICE file for Solr?
> I guess it's fine to keep just to document that there were no
> additional required notices due to the jar, but we shouldn't throw it
> all in our NOTICE file.
> 
> -Yonik
> http://lucidimagination.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org