You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/11/15 13:15:00 UTC

[GitHub] [incubator-doris] liutang123 opened a new pull request #4905: Restructure storage type to support complex types expending

liutang123 opened a new pull request #4905:
URL: https://github.com/apache/incubator-doris/pull/4905


   ## Proposed changes
   
   This CL includes:
   * Change the column metadata to a tree structure.
   * Refactor the segment_v2.ColumnReader and sgment_v2.ColumnWriter to support complex type.
   * Implements the reading and writing of array type.
   
   ## Types of changes
   
   - [] Bugfix (non-breaking change which fixes an issue)
   - [x] New feature (non-breaking change which adds functionality)
   - [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [] Documentation Update (if none of the other choices apply)
   - [x] Code refactor (Modify the code structure, format the code, etc...)
   
   ## Checklist
   
   - [x] I have create an issue on (#2885 ), and have described the feature there in detail
   - [x] Compiling and unit tests pass locally with my changes
   - [x] I have added tests that prove my fix is effective or that my feature works
   - [] If this change need a document change, I have updated the document
   - [] Any dependent changes have been merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] liutang123 edited a comment on pull request #4905: Restructure storage type to support complex types expending

Posted by GitBox <gi...@apache.org>.
liutang123 edited a comment on pull request #4905:
URL: https://github.com/apache/incubator-doris/pull/4905#issuecomment-727569845


   @morningman @wangbo @kangkaisen Hi, this PR is the replacement of #3025. Look forward to reviewing.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] liutang123 commented on pull request #4905: Restructure storage type to support complex types expending

Posted by GitBox <gi...@apache.org>.
liutang123 commented on pull request #4905:
URL: https://github.com/apache/incubator-doris/pull/4905#issuecomment-727569845


   @morningman @wangbo @kangkaisen Hi, this PR is the replacement PR of #3025. Look forward to reviewing.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman merged pull request #4905: Restructure storage type to support complex types expending

Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4905:
URL: https://github.com/apache/incubator-doris/pull/4905


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] wangbo commented on pull request #4905: Restructure storage type to support complex types expending

Posted by GitBox <gi...@apache.org>.
wangbo commented on pull request #4905:
URL: https://github.com/apache/incubator-doris/pull/4905#issuecomment-727864532


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] wangbo removed a comment on pull request #4905: Restructure storage type to support complex types expending

Posted by GitBox <gi...@apache.org>.
wangbo removed a comment on pull request #4905:
URL: https://github.com/apache/incubator-doris/pull/4905#issuecomment-727864532


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org