You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2019/05/27 01:38:25 UTC

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3371: [ZEPPELIN-4171] Configuration paragraph is empty to execute

zjffdu commented on a change in pull request #3371: [ZEPPELIN-4171] Configuration paragraph is empty to execute
URL: https://github.com/apache/zeppelin/pull/3371#discussion_r287625828
 
 

 ##########
 File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Paragraph.java
 ##########
 @@ -344,6 +346,24 @@ public int progress() {
   }
 
   public boolean isBlankParagraph() {
 
 Review comment:
   rename it to shouldSkipRunParagraph. Because what this function doing is not actually checking whether it is blank after this PR. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services