You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by ellisonanne <gi...@git.apache.org> on 2016/10/06 14:14:41 UTC
[GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All Properties in Respo...
GitHub user ellisonanne opened a pull request:
https://github.com/apache/incubator-pirk/pull/106
[PIRK-73] - Change All Properties in ResponderProps to be public
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ellisonanne/incubator-pirk PIRK-73
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #106
----
commit 74a6f11a1af491cc3b722af3fbb25b9342025b64
Author: ellisonanne <ea...@apache.org>
Date: 2016-07-29T19:45:21Z
Merge pull request #5 from apache/master
up
commit 42f3e8400f810377a4bae06638fc13c0e37707f3
Author: ellisonanne <ea...@apache.org>
Date: 2016-07-31T17:47:15Z
Merge pull request #6 from apache/master
updating fork
commit 887358883d26940845a3486b0dc87cd0cc6c3807
Author: ellisonanne <ea...@apache.org>
Date: 2016-08-01T13:06:35Z
Merge pull request #7 from apache/master
up
commit 2ad5c619084af2517cd135374f93be20410cc45c
Author: ellisonanne <ea...@apache.org>
Date: 2016-08-02T16:22:53Z
Merge pull request #8 from apache/master
updating fork
commit d3c6eeb37a0300ea882c0bb2bcd2939132e7e5cb
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-06T14:23:24Z
Merge pull request #9 from apache/master
updating fork
commit 381f3529f97fa38b7b06be015c7b82471c8b95d5
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-11T13:22:15Z
Merge pull request #10 from apache/master
updating fork
commit 6ab035dd32fc4e3464cfb377ccb3493ecf9a313d
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-12T21:19:23Z
Merge pull request #11 from apache/master
up
commit 47a933f9c1d6c6c80f7b61ba5856a84af8162dca
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-13T12:31:25Z
Merge pull request #12 from apache/master
up
commit 6ba5ed4b3ce4983f1e1aa958b6f55180613fa1a1
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-16T13:30:13Z
Merge pull request #13 from apache/master
updating fork
commit 43818205074456b8e16aa09bb408706bfb9608ed
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-18T17:38:55Z
Merge pull request #14 from apache/master
updating fork
commit 9da10044342663526b3456aa894f204f697a2866
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-19T13:54:59Z
Merge pull request #15 from apache/master
updating fork
commit 195c518a8e4d0b131d47fbbe84f8183bdde164ec
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-19T19:00:44Z
Merge pull request #16 from apache/master
various cleanup items - closes apache/incubator-pirk#73
commit c0a060639fa6dc260e16815340e8386d8c296da2
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-23T13:39:27Z
Merge pull request #17 from apache/master
updates
commit 59e706255058afe1a3341c3be6fa2782f0f50442
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-26T13:24:05Z
Merge pull request #18 from apache/master
updat
commit f6495aa177f7d4905e34185ef445087d8b5d9644
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-08-31T13:07:33Z
Merge pull request #20 from apache/master
updating fork
commit 3245592b1fe4f0ba5d2895e1edaa543d264649a1
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-09-06T12:57:04Z
Merge pull request #21 from apache/master
updating fork
commit 3c3157248c14e7f3a7b7a03588520c3107244e50
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-09-13T17:13:52Z
Merge pull request #22 from apache/master
updating fork
commit cef8e6f70634e1b557df6d475c6f12e7bc5783cd
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-09-24T18:44:48Z
Merge pull request #23 from apache/master
updateing
commit d0368fea7844331c5ac25c2aacc19051d516f375
Author: Ellison Anne Williams <ea...@apache.org>
Date: 2016-10-06T13:22:22Z
Merge pull request #24 from apache/master
updating fork
commit 682869c36effb66b551135de8ab69bdc3ac526d8
Author: Ellison Anne Williams <el...@judah.local>
Date: 2016-10-06T13:35:56Z
making props public
commit 5e4ae87fdd39c171f73660cc11d558e58ea68b66
Author: Ellison Anne Williams <el...@judah.local>
Date: 2016-10-06T14:08:04Z
adding props missing from ResponderProps and ResponderCLI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All Properties in Respo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All
Properties in Respo...
Posted by Darin Johnson <db...@gmail.com>.
Sorry wrong thread disregard.
On Oct 6, 2016 6:37 PM, "Darin Johnson" <db...@gmail.com> wrote:
> Being pretty familiar with that section of the code base right now. I
> think a few things could be done. Regardless I'm refactoring it for
> submodules do it'll be easier to iterate these. The main place I'd start is
> currently each platform test creates a new input, which means the querier
> logic is repeated for the number of platforms tested - setting up the test
> inputs once, running all platforms for that test and then tearing down the
> inputs would be a start.
>
> Maybe have all tests implement an interface like:
> Public interface BaseTest {
>
> public void createInputs(...);
>
> public boolean checkOutputs(List results);
> }
>
> The a runner could do:
> BaseTest myTest=new myTest()
> myTest.createInputs(...)
> For(responder:responders)
> {
> results = responder.runDistributedTest();
> If(!myTest.checkResults(results) fail();
> }
>
> If nothing else it'd make adding tests easier.
>
> On Oct 6, 2016 10:14 AM, "ellisonanne" <gi...@git.apache.org> wrote:
>
>> GitHub user ellisonanne opened a pull request:
>>
>> https://github.com/apache/incubator-pirk/pull/106
>>
>> [PIRK-73] - Change All Properties in ResponderProps to be public
>>
>>
>>
>> You can merge this pull request into a Git repository by running:
>>
>> $ git pull https://github.com/ellisonanne/incubator-pirk PIRK-73
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>> https://github.com/apache/incubator-pirk/pull/106.patch
>>
>> To close this pull request, make a commit to your master/trunk branch
>> with (at least) the following in the commit message:
>>
>> This closes #106
>>
>> ----
>> commit 74a6f11a1af491cc3b722af3fbb25b9342025b64
>> Author: ellisonanne <ea...@apache.org>
>> Date: 2016-07-29T19:45:21Z
>>
>> Merge pull request #5 from apache/master
>>
>> up
>>
>> commit 42f3e8400f810377a4bae06638fc13c0e37707f3
>> Author: ellisonanne <ea...@apache.org>
>> Date: 2016-07-31T17:47:15Z
>>
>> Merge pull request #6 from apache/master
>>
>> updating fork
>>
>> commit 887358883d26940845a3486b0dc87cd0cc6c3807
>> Author: ellisonanne <ea...@apache.org>
>> Date: 2016-08-01T13:06:35Z
>>
>> Merge pull request #7 from apache/master
>>
>> up
>>
>> commit 2ad5c619084af2517cd135374f93be20410cc45c
>> Author: ellisonanne <ea...@apache.org>
>> Date: 2016-08-02T16:22:53Z
>>
>> Merge pull request #8 from apache/master
>>
>> updating fork
>>
>> commit d3c6eeb37a0300ea882c0bb2bcd2939132e7e5cb
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-08-06T14:23:24Z
>>
>> Merge pull request #9 from apache/master
>>
>> updating fork
>>
>> commit 381f3529f97fa38b7b06be015c7b82471c8b95d5
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-08-11T13:22:15Z
>>
>> Merge pull request #10 from apache/master
>>
>> updating fork
>>
>> commit 6ab035dd32fc4e3464cfb377ccb3493ecf9a313d
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-08-12T21:19:23Z
>>
>> Merge pull request #11 from apache/master
>>
>> up
>>
>> commit 47a933f9c1d6c6c80f7b61ba5856a84af8162dca
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-08-13T12:31:25Z
>>
>> Merge pull request #12 from apache/master
>>
>> up
>>
>> commit 6ba5ed4b3ce4983f1e1aa958b6f55180613fa1a1
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-08-16T13:30:13Z
>>
>> Merge pull request #13 from apache/master
>>
>> updating fork
>>
>> commit 43818205074456b8e16aa09bb408706bfb9608ed
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-08-18T17:38:55Z
>>
>> Merge pull request #14 from apache/master
>>
>> updating fork
>>
>> commit 9da10044342663526b3456aa894f204f697a2866
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-08-19T13:54:59Z
>>
>> Merge pull request #15 from apache/master
>>
>> updating fork
>>
>> commit 195c518a8e4d0b131d47fbbe84f8183bdde164ec
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-08-19T19:00:44Z
>>
>> Merge pull request #16 from apache/master
>>
>> various cleanup items - closes apache/incubator-pirk#73
>>
>> commit c0a060639fa6dc260e16815340e8386d8c296da2
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-08-23T13:39:27Z
>>
>> Merge pull request #17 from apache/master
>>
>> updates
>>
>> commit 59e706255058afe1a3341c3be6fa2782f0f50442
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-08-26T13:24:05Z
>>
>> Merge pull request #18 from apache/master
>>
>> updat
>>
>> commit f6495aa177f7d4905e34185ef445087d8b5d9644
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-08-31T13:07:33Z
>>
>> Merge pull request #20 from apache/master
>>
>> updating fork
>>
>> commit 3245592b1fe4f0ba5d2895e1edaa543d264649a1
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-09-06T12:57:04Z
>>
>> Merge pull request #21 from apache/master
>>
>> updating fork
>>
>> commit 3c3157248c14e7f3a7b7a03588520c3107244e50
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-09-13T17:13:52Z
>>
>> Merge pull request #22 from apache/master
>>
>> updating fork
>>
>> commit cef8e6f70634e1b557df6d475c6f12e7bc5783cd
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-09-24T18:44:48Z
>>
>> Merge pull request #23 from apache/master
>>
>> updateing
>>
>> commit d0368fea7844331c5ac25c2aacc19051d516f375
>> Author: Ellison Anne Williams <ea...@apache.org>
>> Date: 2016-10-06T13:22:22Z
>>
>> Merge pull request #24 from apache/master
>>
>> updating fork
>>
>> commit 682869c36effb66b551135de8ab69bdc3ac526d8
>> Author: Ellison Anne Williams <el...@judah.local>
>> Date: 2016-10-06T13:35:56Z
>>
>> making props public
>>
>> commit 5e4ae87fdd39c171f73660cc11d558e58ea68b66
>> Author: Ellison Anne Williams <el...@judah.local>
>> Date: 2016-10-06T14:08:04Z
>>
>> adding props missing from ResponderProps and ResponderCLI
>>
>> ----
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
Re: [GitHub] incubator-pirk pull request #106: [PIRK-73] - Change All
Properties in Respo...
Posted by Darin Johnson <db...@gmail.com>.
Being pretty familiar with that section of the code base right now. I
think a few things could be done. Regardless I'm refactoring it for
submodules do it'll be easier to iterate these. The main place I'd start is
currently each platform test creates a new input, which means the querier
logic is repeated for the number of platforms tested - setting up the test
inputs once, running all platforms for that test and then tearing down the
inputs would be a start.
Maybe have all tests implement an interface like:
Public interface BaseTest {
public void createInputs(...);
public boolean checkOutputs(List results);
}
The a runner could do:
BaseTest myTest=new myTest()
myTest.createInputs(...)
For(responder:responders)
{
results = responder.runDistributedTest();
If(!myTest.checkResults(results) fail();
}
If nothing else it'd make adding tests easier.
On Oct 6, 2016 10:14 AM, "ellisonanne" <gi...@git.apache.org> wrote:
> GitHub user ellisonanne opened a pull request:
>
> https://github.com/apache/incubator-pirk/pull/106
>
> [PIRK-73] - Change All Properties in ResponderProps to be public
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/ellisonanne/incubator-pirk PIRK-73
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/incubator-pirk/pull/106.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #106
>
> ----
> commit 74a6f11a1af491cc3b722af3fbb25b9342025b64
> Author: ellisonanne <ea...@apache.org>
> Date: 2016-07-29T19:45:21Z
>
> Merge pull request #5 from apache/master
>
> up
>
> commit 42f3e8400f810377a4bae06638fc13c0e37707f3
> Author: ellisonanne <ea...@apache.org>
> Date: 2016-07-31T17:47:15Z
>
> Merge pull request #6 from apache/master
>
> updating fork
>
> commit 887358883d26940845a3486b0dc87cd0cc6c3807
> Author: ellisonanne <ea...@apache.org>
> Date: 2016-08-01T13:06:35Z
>
> Merge pull request #7 from apache/master
>
> up
>
> commit 2ad5c619084af2517cd135374f93be20410cc45c
> Author: ellisonanne <ea...@apache.org>
> Date: 2016-08-02T16:22:53Z
>
> Merge pull request #8 from apache/master
>
> updating fork
>
> commit d3c6eeb37a0300ea882c0bb2bcd2939132e7e5cb
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-08-06T14:23:24Z
>
> Merge pull request #9 from apache/master
>
> updating fork
>
> commit 381f3529f97fa38b7b06be015c7b82471c8b95d5
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-08-11T13:22:15Z
>
> Merge pull request #10 from apache/master
>
> updating fork
>
> commit 6ab035dd32fc4e3464cfb377ccb3493ecf9a313d
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-08-12T21:19:23Z
>
> Merge pull request #11 from apache/master
>
> up
>
> commit 47a933f9c1d6c6c80f7b61ba5856a84af8162dca
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-08-13T12:31:25Z
>
> Merge pull request #12 from apache/master
>
> up
>
> commit 6ba5ed4b3ce4983f1e1aa958b6f55180613fa1a1
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-08-16T13:30:13Z
>
> Merge pull request #13 from apache/master
>
> updating fork
>
> commit 43818205074456b8e16aa09bb408706bfb9608ed
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-08-18T17:38:55Z
>
> Merge pull request #14 from apache/master
>
> updating fork
>
> commit 9da10044342663526b3456aa894f204f697a2866
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-08-19T13:54:59Z
>
> Merge pull request #15 from apache/master
>
> updating fork
>
> commit 195c518a8e4d0b131d47fbbe84f8183bdde164ec
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-08-19T19:00:44Z
>
> Merge pull request #16 from apache/master
>
> various cleanup items - closes apache/incubator-pirk#73
>
> commit c0a060639fa6dc260e16815340e8386d8c296da2
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-08-23T13:39:27Z
>
> Merge pull request #17 from apache/master
>
> updates
>
> commit 59e706255058afe1a3341c3be6fa2782f0f50442
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-08-26T13:24:05Z
>
> Merge pull request #18 from apache/master
>
> updat
>
> commit f6495aa177f7d4905e34185ef445087d8b5d9644
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-08-31T13:07:33Z
>
> Merge pull request #20 from apache/master
>
> updating fork
>
> commit 3245592b1fe4f0ba5d2895e1edaa543d264649a1
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-09-06T12:57:04Z
>
> Merge pull request #21 from apache/master
>
> updating fork
>
> commit 3c3157248c14e7f3a7b7a03588520c3107244e50
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-09-13T17:13:52Z
>
> Merge pull request #22 from apache/master
>
> updating fork
>
> commit cef8e6f70634e1b557df6d475c6f12e7bc5783cd
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-09-24T18:44:48Z
>
> Merge pull request #23 from apache/master
>
> updateing
>
> commit d0368fea7844331c5ac25c2aacc19051d516f375
> Author: Ellison Anne Williams <ea...@apache.org>
> Date: 2016-10-06T13:22:22Z
>
> Merge pull request #24 from apache/master
>
> updating fork
>
> commit 682869c36effb66b551135de8ab69bdc3ac526d8
> Author: Ellison Anne Williams <el...@judah.local>
> Date: 2016-10-06T13:35:56Z
>
> making props public
>
> commit 5e4ae87fdd39c171f73660cc11d558e58ea68b66
> Author: Ellison Anne Williams <el...@judah.local>
> Date: 2016-10-06T14:08:04Z
>
> adding props missing from ResponderProps and ResponderCLI
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-pirk issue #106: [PIRK-73] - Change All Properties in ResponderPro...
Posted by wraydulany <gi...@git.apache.org>.
Github user wraydulany commented on the issue:
https://github.com/apache/incubator-pirk/pull/106
+1 This what I expected from the JIRA. Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---