[GitHub] [shardingsphere] mabaiwan commented on a diff in pull request #18665: add POLYGON metadata

[GitBox <gi...@apache.org>]

mabaiwan commented on code in PR #18665:
URL: https://github.com/apache/shardingsphere/pull/18665#discussion_r908586462


##########
shardingsphere-infra/shardingsphere-infra-common/src/test/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/dialect/MySQLSchemaMetaDataLoaderTest.java:
##########
@@ -88,12 +88,12 @@ private ResultSet mockTypeInfoResultSet() throws SQLException {
     
     private ResultSet mockTableMetaDataResultSet() throws SQLException {
         ResultSet result = mock(ResultSet.class);
-        when(result.next()).thenReturn(true, true, true, true, true, true, false);
+        when(result.next()).thenReturn(true, true, true, true, true, true, true, false);
         when(result.getString("TABLE_NAME")).thenReturn("tbl");
-        when(result.getString("COLUMN_NAME")).thenReturn("id", "name", "doc", "geo", "t_year", "mp");
-        when(result.getString("DATA_TYPE")).thenReturn("int", "varchar", "json", "geometry", "year", "multipolygon");
-        when(result.getString("COLUMN_KEY")).thenReturn("PRI", "", "", "", "", "");
-        when(result.getString("EXTRA")).thenReturn("auto_increment", "", "", "", "", "");
+        when(result.getString("COLUMN_NAME")).thenReturn("id", "name", "doc", "geo", "t_year", "pg", "mpg");

Review Comment:
   @lcxywfe Why change from mg to mpg?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org