[GitHub] [flink] StephanEwen commented on a change in pull request #8895: [FLINK-12536][Runtime/Network]Make BufferOrEventSequence#getNext non blocking

[GitBox <gi...@apache.org>]

StephanEwen commented on a change in pull request #8895: [FLINK-12536][Runtime/Network]Make BufferOrEventSequence#getNext non blocking
URL: https://github.com/apache/flink/pull/8895#discussion_r299346369
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManager.java
 ##########
 @@ -224,6 +238,8 @@ public void deleteChannel(FileIOChannel.ID channel) throws IOException {
 
 	public abstract BufferFileReader createBufferFileReader(FileIOChannel.ID channelID, RequestDoneCallback<Buffer> callback) throws IOException;
 
+	public abstract BufferFileReader createBufferOrEventFileReader(FileIOChannel.ID channelID, RequestDoneCallback<Buffer> callback) throws IOException;
 
 Review comment:
   If we go forward, I would suggest to factor this out into an interface (that is also implemented by `IOManager`) so we do not pass such a big dependency. This component does not need to know about the IOManager as a whole if it is only interested in this sub-functionality.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services