You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/13 22:44:07 UTC
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9296: [DEV] Allow webpack-dev-server proxy to any destination
ktmud commented on a change in pull request #9296: [DEV] Allow webpack-dev-server proxy to any destination
URL: https://github.com/apache/incubator-superset/pull/9296#discussion_r392517240
##########
File path: superset-frontend/package.json
##########
@@ -236,7 +236,8 @@
"webpack-bundle-analyzer": "^3.4.1",
"webpack-cli": "^3.1.1",
"webpack-dev-server": "^3.1.14",
- "webpack-sources": "^1.1.0"
+ "webpack-sources": "^1.1.0",
+ "yargs": "12 - 15"
Review comment:
Replace `minimist` with `yargs` as the latter has better API and is included by other packages anyway. Choose this wide range (`12 -15`) also because it is tested working with the latest version but other packages still depend on v12.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org