You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Tomas Havelka (JIRA)" <de...@myfaces.apache.org> on 2007/06/28 17:14:26 UTC
[jira] Created: (TRINIDAD-81) Wrong converting of CSS pseudo
classes
Wrong converting of CSS pseudo classes
--------------------------------------
Key: TRINIDAD-81
URL: https://issues.apache.org/jira/browse/TRINIDAD-81
Project: MyFaces Trinidad
Issue Type: Bug
Components: Skinning
Affects Versions: 1.0.1-core
Reporter: Tomas Havelka
Stylesheet's pseudo classes selectors are converted badly. Only selectors which exactly ends with pseudo classes are converted correctly, others not. For example selector ".BFGlobalButton a.OraLink:hover img" is converted to ".BFGlobalButton a.OraLink.p_AFHover img" because CSSGenerationUtils does not recognize correctly stylesheet pseudo class. In previous release (1.0.1-incubating) everything works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-81) Wrong converting of CSS pseudo
classes
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe updated TRINIDAD-81:
-----------------------------------
Status: Patch Available (was: Open)
> Wrong converting of CSS pseudo classes
> --------------------------------------
>
> Key: TRINIDAD-81
> URL: https://issues.apache.org/jira/browse/TRINIDAD-81
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 1.0.1-core
> Reporter: Tomas Havelka
>
> Stylesheet's pseudo classes selectors are converted badly. Only selectors which exactly ends with pseudo classes are converted correctly, others not. For example selector ".BFGlobalButton a.OraLink:hover img" is converted to ".BFGlobalButton a.OraLink.p_AFHover img" because CSSGenerationUtils does not recognize correctly stylesheet pseudo class. In previous release (1.0.1-incubating) everything works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-81) Wrong converting of CSS pseudo
classes
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman updated TRINIDAD-81:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
thanks for the patch. I tested it and it works fine.
I reformatted the '{'s and added some more comments.
> Wrong converting of CSS pseudo classes
> --------------------------------------
>
> Key: TRINIDAD-81
> URL: https://issues.apache.org/jira/browse/TRINIDAD-81
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 1.0.1-core
> Reporter: Tomas Havelka
> Assignee: Jeanne Waldman
> Attachments: patch4.patch
>
>
> Stylesheet's pseudo classes selectors are converted badly. Only selectors which exactly ends with pseudo classes are converted correctly, others not. For example selector ".BFGlobalButton a.OraLink:hover img" is converted to ".BFGlobalButton a.OraLink.p_AFHover img" because CSSGenerationUtils does not recognize correctly stylesheet pseudo class. In previous release (1.0.1-incubating) everything works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-81) Wrong converting of CSS pseudo
classes
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508852 ]
Matthias Weßendorf commented on TRINIDAD-81:
--------------------------------------------
TRINIDAD-81 was created twice...
> Wrong converting of CSS pseudo classes
> --------------------------------------
>
> Key: TRINIDAD-81
> URL: https://issues.apache.org/jira/browse/TRINIDAD-81
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 1.0.1-core
> Reporter: Tomas Havelka
>
> Stylesheet's pseudo classes selectors are converted badly. Only selectors which exactly ends with pseudo classes are converted correctly, others not. For example selector ".BFGlobalButton a.OraLink:hover img" is converted to ".BFGlobalButton a.OraLink.p_AFHover img" because CSSGenerationUtils does not recognize correctly stylesheet pseudo class. In previous release (1.0.1-incubating) everything works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-81) Wrong converting of CSS pseudo
classes
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513051 ]
Jeanne Waldman commented on TRINIDAD-81:
----------------------------------------
I could also reproduce this problem. This problem was probably introduced when I recently added code for this use case:
*:active, .AFFoo:read-only {
}
I wanted this to be:
*:active, .AFFoo.p_AFReadOnly {
}
This was issue:
wild-carded skinning pseudo classes incorrectly transformed to CSS-2
I'll take a look at this patch.
FYI - whenever you change skinning code, you should run the simple and the purple skins before your change in compressed and uncompressed mode and save the rendered css file and compare it after your change to make sure it hasn't changed unexpectedly.
Thanks!
Jeanne
> Wrong converting of CSS pseudo classes
> --------------------------------------
>
> Key: TRINIDAD-81
> URL: https://issues.apache.org/jira/browse/TRINIDAD-81
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 1.0.1-core
> Reporter: Tomas Havelka
> Assignee: Jeanne Waldman
> Attachments: patch4.patch
>
>
> Stylesheet's pseudo classes selectors are converted badly. Only selectors which exactly ends with pseudo classes are converted correctly, others not. For example selector ".BFGlobalButton a.OraLink:hover img" is converted to ".BFGlobalButton a.OraLink.p_AFHover img" because CSSGenerationUtils does not recognize correctly stylesheet pseudo class. In previous release (1.0.1-incubating) everything works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TRINIDAD-81) Wrong converting of CSS pseudo
classes
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman resolved TRINIDAD-81.
------------------------------------
Resolution: Fixed
svn 561178
> Wrong converting of CSS pseudo classes
> --------------------------------------
>
> Key: TRINIDAD-81
> URL: https://issues.apache.org/jira/browse/TRINIDAD-81
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 1.0.1-core
> Reporter: Tomas Havelka
> Assignee: Jeanne Waldman
> Attachments: patch4.patch
>
>
> Stylesheet's pseudo classes selectors are converted badly. Only selectors which exactly ends with pseudo classes are converted correctly, others not. For example selector ".BFGlobalButton a.OraLink:hover img" is converted to ".BFGlobalButton a.OraLink.p_AFHover img" because CSSGenerationUtils does not recognize correctly stylesheet pseudo class. In previous release (1.0.1-incubating) everything works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TRINIDAD-81) Wrong converting of CSS pseudo
classes
Posted by "Jeanne Waldman (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman reopened TRINIDAD-81:
------------------------------------
I notice that the fix is commented out. My fault. I'll fix it and resubmit the change.
> Wrong converting of CSS pseudo classes
> --------------------------------------
>
> Key: TRINIDAD-81
> URL: https://issues.apache.org/jira/browse/TRINIDAD-81
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 1.0.1-core
> Reporter: Tomas Havelka
> Assignee: Jeanne Waldman
> Attachments: patch4.patch
>
>
> Stylesheet's pseudo classes selectors are converted badly. Only selectors which exactly ends with pseudo classes are converted correctly, others not. For example selector ".BFGlobalButton a.OraLink:hover img" is converted to ".BFGlobalButton a.OraLink.p_AFHover img" because CSSGenerationUtils does not recognize correctly stylesheet pseudo class. In previous release (1.0.1-incubating) everything works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.