You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by gr...@apache.org on 2017/11/15 20:38:10 UTC
[incubator-superset] branch master updated: [dashboard bug] Fix
standalone slice (#3877)
This is an automated email from the ASF dual-hosted git repository.
graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 120a5d0 [dashboard bug] Fix standalone slice (#3877)
120a5d0 is described below
commit 120a5d08f9127449fbae0e7ece25ccfbdc3718a8
Author: Grace Guo <gr...@airbnb.com>
AuthorDate: Wed Nov 15 12:38:07 2017 -0800
[dashboard bug] Fix standalone slice (#3877)
---
.../explore/components/ExploreChartPanel.jsx | 28 +++++++++++++---------
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/superset/assets/javascripts/explore/components/ExploreChartPanel.jsx b/superset/assets/javascripts/explore/components/ExploreChartPanel.jsx
index 7834787..abb1bc0 100644
--- a/superset/assets/javascripts/explore/components/ExploreChartPanel.jsx
+++ b/superset/assets/javascripts/explore/components/ExploreChartPanel.jsx
@@ -32,6 +32,22 @@ class ExploreChartPanel extends React.PureComponent {
return parseInt(this.props.height, 10) - headerHeight;
}
+ renderChart() {
+ return (
+ <ChartContainer
+ containerId={this.props.containerId}
+ datasource={this.props.datasource}
+ formData={this.props.form_data}
+ height={this.getHeight()}
+ slice={this.props.slice}
+ chartKey={this.props.chart.chartKey}
+ setControlValue={this.props.actions.setControlValue}
+ timeout={this.props.timeout}
+ vizType={this.props.vizType}
+ />
+ );
+ }
+
render() {
if (this.props.standalone) {
// dom manipulation hack to get rid of the boostrap theme's body background
@@ -57,17 +73,7 @@ class ExploreChartPanel extends React.PureComponent {
style={{ height: this.props.height }}
header={header}
>
- <ChartContainer
- containerId={this.props.containerId}
- datasource={this.props.datasource}
- formData={this.props.form_data}
- height={this.getHeight()}
- slice={this.props.slice}
- chartKey={this.props.chart.chartKey}
- setControlValue={this.props.actions.setControlValue}
- timeout={this.props.timeout}
- vizType={this.props.vizType}
- />
+ {this.renderChart()}
</Panel>
</div>
);
--
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <co...@superset.apache.org>'].