[GitHub] [iceberg] nastra commented on a diff in pull request #7481: Flink: Remove deprecated AssertHelpers

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #7481:
URL: https://github.com/apache/iceberg/pull/7481#discussion_r1181486897


##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java:
##########
@@ -378,16 +371,14 @@ public void testOverrideWriteConfigWithUnknownFileFormat() {
             .writeParallelism(parallelism)
             .setAll(newProps);
 
-    AssertHelpers.assertThrows(
-        "Should fail with invalid file format.",
-        IllegalArgumentException.class,
-        "Invalid file format: UNRECOGNIZED",
-        () -> {
-          builder.append();
-
-          // Execute the program.
-          env.execute("Test Iceberg DataStream.");
-          return null;
-        });
+    Assertions.assertThatThrownBy(
+            () -> {
+              builder.append();
+
+              // Execute the program.
+              env.execute("Test Iceberg DataStream.");

Review Comment:
   I think we should remove the call to `env.execute("Test Iceberg DataStream.");` because it implies that the error happens on that call, whereas in fact it happens when calling `builder.append()`
   
   ```
   Assertions.assertThatThrownBy(builder::append)
           .isInstanceOf(IllegalArgumentException.class)
           .hasMessage("Invalid file format: UNRECOGNIZED");
   ```



##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java:
##########
@@ -350,17 +345,15 @@ public void testOverrideWriteConfigWithUnknownDistributionMode() {
             .writeParallelism(parallelism)
             .setAll(newProps);
 
-    AssertHelpers.assertThrows(
-        "Should fail with invalid distribution mode.",
-        IllegalArgumentException.class,
-        "Invalid distribution mode: UNRECOGNIZED",
-        () -> {
-          builder.append();
-
-          // Execute the program.
-          env.execute("Test Iceberg DataStream.");
-          return null;
-        });
+    Assertions.assertThatThrownBy(
+            () -> {
+              builder.append();
+
+              // Execute the program.
+              env.execute("Test Iceberg DataStream.");

Review Comment:
   I think we should remove the call to `env.execute("Test Iceberg DataStream.");` because it implies that the error happens on that call, whereas in fact it happens when calling `builder.append()`
   
   ```
   Assertions.assertThatThrownBy(builder::append)
           .isInstanceOf(IllegalArgumentException.class)
           .hasMessage("Invalid distribution mode: UNRECOGNIZED");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org