[jira] [Commented] (DRILL-2025) some tests don't re-use Drillbits, seem slower than necessary

["Deneche A. Hakim (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282772#comment-14282772 ] 

Deneche A. Hakim commented on DRILL-2025:
-----------------------------------------

The following test will be updated as part of DRILL-1908 and will reuse the same Drillbit for all it's tests:

org.apache.drill.exec.physical.impl.window.TestWindowFrame

> some tests don't re-use Drillbits, seem slower than necessary
> -------------------------------------------------------------
>
>                 Key: DRILL-2025
>                 URL: https://issues.apache.org/jira/browse/DRILL-2025
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build & Test
>            Reporter: Daniel Barclay (Drill/MapR)
>            Assignee: Jacques Nadeau
>
> Regarding tests  that require running a Drillbit:
> In many (maybe even most) cases, a test class creates a Drillbit instance that is re-used by all the test methods in that class, so that each test method only takes about a second or less to run.
> However, there are a number of test classes that run much more slowly because the class doesn't reuse a Drillbit, so each of its test methods starts up and shuts down its own Drillbit instance, so each test method takes about 7 to 10 seconds to run, making the test class and the overall test suite take considerably longer than seems necessary.
> Except for any test methods that really do need their own instance of Drillbit, those slower test classes should be adjusted to re-use Drillbits as many other classes do.
> Some slower, apparently non-sharing test classes are:
> org.apache.drill.jdbc.test.TestMetadataDDL (30 methods)
> org.apache.drill.jdbc.test.TestViews (20 methods)
> org.apache.drill.jdbc.test.TestJdbcQuery (20 methods)
> org.apache.drill.jdbc.test.TestJdbcDistQuery (12 methods)
> org.apache.drill.exec.physical.impl.TestDecimal (6 methods)
> org.apache.drill.exec.record.vector.TestDateTypes (6 methods)
> org.apache.drill.jdbc.test.TestHiveStorage (5 methods)
> org.apache.drill.exec.physical.impl.TestExtractFunctions (5 methods)
> org.apache.drill.exec.expr.ExpressionInterpreterTest (4 methods)
> org.apache.drill.exec.fn.impl.TestDateFunctions (3 methods)
> org.apache.drill.exec.physical.impl.TestDistributedFragmentRun (3 methods)
> org.apache.drill.exec.physical.impl.window.TestWindowFrame (3 methods)
> org.apache.drill.exec.physical.impl.TestSimpleFragmentRun (3 methods)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)