You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/02/01 21:31:00 UTC
[jira] [Work logged] (BEAM-11719) Enforce deterministic coding for
GroupByKey and Stateful DoFns
[ https://issues.apache.org/jira/browse/BEAM-11719?focusedWorklogId=545605&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-545605 ]
ASF GitHub Bot logged work on BEAM-11719:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/21 21:30
Start Date: 01/Feb/21 21:30
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #13839:
URL: https://github.com/apache/beam/pull/13839#issuecomment-771172066
# [Codecov](https://codecov.io/gh/apache/beam/pull/13839?src=pr&el=h1) Report
> Merging [#13839](https://codecov.io/gh/apache/beam/pull/13839?src=pr&el=desc) (79301c4) into [master](https://codecov.io/gh/apache/beam/commit/297548718cc69ddd30f8c7d1aec6285d6e13ad8c?el=desc) (2975487) will **increase** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/beam/pull/13839?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13839 +/- ##
==========================================
+ Coverage 82.78% 82.85% +0.06%
==========================================
Files 466 466
Lines 57557 57608 +51
==========================================
+ Hits 47647 47729 +82
+ Misses 9910 9879 -31
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13839?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/13839/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `89.87% <ø> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/13839/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `74.55% <ø> (ø)` | |
| [sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/13839/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `95.38% <100.00%> (+0.13%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/13839/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `87.55% <100.00%> (+0.29%)` | :arrow_up: |
| [...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/13839/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2ZpbGVfbG9hZHMucHk=) | `90.50% <100.00%> (+0.02%)` | :arrow_up: |
| [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/13839/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `91.17% <100.00%> (+0.06%)` | :arrow_up: |
| [sdks/python/apache\_beam/pvalue.py](https://codecov.io/gh/apache/beam/pull/13839/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcHZhbHVlLnB5) | `92.48% <100.00%> (+0.02%)` | :arrow_up: |
| [...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/13839/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=) | `83.09% <100.00%> (+4.63%)` | :arrow_up: |
| [...dks/python/apache\_beam/runners/pipeline\_context.py](https://codecov.io/gh/apache/beam/pull/13839/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9waXBlbGluZV9jb250ZXh0LnB5) | `92.91% <100.00%> (+0.17%)` | :arrow_up: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/13839/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.85% <0.00%> (-2.39%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/beam/pull/13839/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13839?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13839?src=pr&el=footer). Last update [280107a...79301c4](https://codecov.io/gh/apache/beam/pull/13839?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 545605)
Remaining Estimate: 0h
Time Spent: 10m
> Enforce deterministic coding for GroupByKey and Stateful DoFns
> --------------------------------------------------------------
>
> Key: BEAM-11719
> URL: https://issues.apache.org/jira/browse/BEAM-11719
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: P1
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If a non-deterministic coder, such as pickling, is used for keys this can result in two copies of the same key being grouped separately (based on their encodings).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)