[jira] Updated: (AXISCPP-721) Axis###Exception::getMessage() returns a static variable

["Dushshantha Chandradasa (JIRA)" <ax...@ws.apache.org>]

     [ http://issues.apache.org/jira/browse/AXISCPP-721?page=all ]

Dushshantha Chandradasa updated AXISCPP-721:
--------------------------------------------

    Attachment: ExceptionModel_before.JPG

Samisa wrote: 


PFA the class diagram of current exception model we have.

            

            Looking into the several issues we have against the exception model, it is worth considering a re-arrangement here.

http://issues.apache.org/jira/browse/AXISCPP-707

http://issues.apache.org/jira/browse/AXISCPP-721

http://issues.apache.org/jira/browse/AXISCPP-722

 

            The idea is *very* simple here.  (basic OO stuff)

1.       We have m_sMessage and m_iExceptionCode as data members in all the derived classes – move them to base class. Move the access methods to the base class as well.

2.       Drop all processException() methods and move the logic to constructor

3.       getMessage() methods in the derived classes do not get the message rather return the message corresponding to the exception code. Hence rename getMessage() getMessageForExceptionCode()

4.       We have “what()” in the base class to get the error message. This is a virtual method inherited from the ‘exception’ class hence we cannot change the naming. However, better to have a more sensible name like getMessage to wrap this

5.       There are too many constructors in the derived classes, I would like only two constructors for each class

a.       Copy constructor

b.       Constructor with 2 parameters, exception code and message, with message defaulting to null. ExceptionClass(int code, char* msg = null)

 



> Axis###Exception::getMessage() returns a static variable
> --------------------------------------------------------
>
>          Key: AXISCPP-721
>          URL: http://issues.apache.org/jira/browse/AXISCPP-721
>      Project: Axis-C++
>         Type: Bug
>   Components: Server - Engine
>     Versions: current (nightly)
>     Reporter: Henrik Nordberg
>     Assignee: Dushshantha Chandradasa
>     Priority: Minor
>  Attachments: ExceptionModel_before.JPG
>
> Axis exceptions' method getMessage() returns a static variable. Here is an example of the code for AxisSoapException:
> const string AxisSoapException::getMessage (const exception* objException)
> {
>     static string objExDetail = objException->what();
>     return objExDetail;
> }
> What is the purpose of making objExDetail static? Doing so means that it is initialized the first time this method is called (once per instance of the class), and after that the same value will be returned no matter what objException is. Here is a version without static:
> string AxisSoapException::getMessage (const exception& objException) const {
>     return objException.what();
> }
> I also made the method const since we will not modify members. Also why use a pointer when we don't have to? :)
> I also think that since this code is common between Axis exceptions, it should be move to a common base class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira