You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/22 03:29:28 UTC

[GitHub] [pulsar] Anonymitaet opened a new pull request #10317: [Doc] Add guides for end-to-end encryption in Node.js client

Anonymitaet opened a new pull request #10317:
URL: https://github.com/apache/pulsar/pull/10317


   Add docs for https://github.com/apache/pulsar-client-node/pull/138.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #10317: [Doc] Add guides for end-to-end encryption in Node.js client

Posted by GitBox <gi...@apache.org>.
Anonymitaet edited a comment on pull request #10317:
URL: https://github.com/apache/pulsar/pull/10317#issuecomment-829055022


   @eolivelli I've added docs for both 2.7.2 and master, so users can read this content in 2.7.2 and master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10317: [Doc] Add guides for end-to-end encryption in Node.js client

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10317:
URL: https://github.com/apache/pulsar/pull/10317#issuecomment-824511393


   @zymap @tuteng @Huanli-Meng @Jennifer88huang could you please help review? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tuteng commented on a change in pull request #10317: [Doc] Add guides for end-to-end encryption in Node.js client

Posted by GitBox <gi...@apache.org>.
tuteng commented on a change in pull request #10317:
URL: https://github.com/apache/pulsar/pull/10317#discussion_r618799655



##########
File path: site2/docs/client-libraries-node.md
##########
@@ -27,7 +27,7 @@ Compatibility between each version of the Node.js client and the C++ client is a
 | 1.0.0          | 2.3.0 or later |
 | 1.1.0          | 2.4.0 or later |
 | 1.2.0          | 2.5.0 or later |
-| 1.3.0          | 2.7.0 or later |
+| 1.3.0          | 2.7.1 or later |

Review comment:
       I think 1.3.0 does not support this feature, we need to wait for the next release of the node client




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10317: [Doc] Add guides for end-to-end encryption in Node.js client

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #10317:
URL: https://github.com/apache/pulsar/pull/10317#discussion_r618820609



##########
File path: site2/docs/client-libraries-node.md
##########
@@ -27,7 +27,7 @@ Compatibility between each version of the Node.js client and the C++ client is a
 | 1.0.0          | 2.3.0 or later |
 | 1.1.0          | 2.4.0 or later |
 | 1.2.0          | 2.5.0 or later |
-| 1.3.0          | 2.7.0 or later |
+| 1.3.0          | 2.7.1 or later |

Review comment:
       @tuteng OK, then I've removed `| 1.3.0          | 2.7.1 or later |` for both master and 2.7.2. PTAL.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #10317: [Doc] Add guides for end-to-end encryption in Node.js client

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10317:
URL: https://github.com/apache/pulsar/pull/10317#issuecomment-829019934


   I am removing 2.7.2 label,
   does are built from master, correct ?
   @Anonymitaet 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #10317: [Doc] Add guides for end-to-end encryption in Node.js client

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10317:
URL: https://github.com/apache/pulsar/pull/10317#issuecomment-829055022


   @eolivelli I've added docs for both 2.7.2 and master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet merged pull request #10317: [Doc] Add guides for end-to-end encryption in Node.js client

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #10317:
URL: https://github.com/apache/pulsar/pull/10317


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org