[GitHub] [incubator-marvin] lucasbmiguel commented on a change in pull request #37: Bigquery support

[GitBox <gi...@apache.org>]

lucasbmiguel commented on a change in pull request #37: Bigquery support
URL: https://github.com/apache/incubator-marvin/pull/37#discussion_r349854494
 
 

 ##########
 File path: python-toolbox/setup.py
 ##########
 @@ -91,9 +93,9 @@
     'pytest>=2.9.2',
     'pytest-cov>=1.8.1,<2.6',
     'pytest-watch>=4.1.0',
-    'pytest-testmon>=0.8.2',
+    'pytest-testmon==0.8.2',
     'Keras>=2.2.0',
-    'tensorflow>=1.8.0',
+    'tensorflow==2.0',
 
 Review comment:
   Is upgrading the version of tensorflow something required to allow data sample import from big query? If not I recommend deal with it as a separate commit/MR, just so that it's easy for other users to find in which version we introduced compatibility break to old version of 3rd party frameworks like tensorflow. Other than that the MR lgtm

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services