You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2023/07/19 13:59:32 UTC

[GitHub] [netbeans] mbien opened a new pull request, #6228: Revert "Use resolve() method that actually throws exception."

mbien opened a new pull request, #6228:
URL: https://github.com/apache/netbeans/pull/6228

   This reverts commit e2a14bf32a5bddabee71e0fc2e35f575f7d1aacc.
   
   fixes #6222 ArtifactResolutionExceptions when working with maven projects
   
   regression reproducible in RC1, see issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] neilcsmith-net merged pull request #6228: Revert "Use resolve() method that actually throws exception."

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net merged PR #6228:
URL: https://github.com/apache/netbeans/pull/6228


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] neilcsmith-net commented on pull request #6228: Revert "Use resolve() method that actually throws exception."

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6228:
URL: https://github.com/apache/netbeans/pull/6228#issuecomment-1642404651

   > I don't think that just throwing out a change is a good idea;
   
   Personally, I'm in favour of fast revert on regression, on both master (which is always meant to be release ready) and especially on delivery.  Then introduce the corrected change via another PR taking care to review against the regression.  Otherwise, some things become harder to revert later.
   
   In short, +1 to this PR, and we should take this approach more often.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] sdedic commented on pull request #6228: Revert "Use resolve() method that actually throws exception."

Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #6228:
URL: https://github.com/apache/netbeans/pull/6228#issuecomment-1642366550

   I don't think that just throwing out a change is a good idea; without the change, the `resolve` method actually does not report ArtifactNotFound resolution failures (it returns artifacts that have isResolved() == false) and does not respect well recorded artifact origin (which was the reason for changing the implementation). In addition, the reason of inability to resolve the artiact (isResolved() == false) is discarded during the course.
   
   I an on vacation, and not really able to make a change until Sun 23; an option would be to have two `resolve()` methods - one broken retaining the old behaviour, the other the corrected one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #6228: Revert "Use resolve() method that actually throws exception."

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6228:
URL: https://github.com/apache/netbeans/pull/6228#issuecomment-1642388945

   I am sure there are good reasons to propagate the exception down to the API users but this can't be simply enabled without making sure all API users are prepared for this change. Thats why this is causing regressions. I don't want to start fixing things during the RC phase, we can apply this again for NB 20 and stabilize is there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #6228: Revert "Use resolve() method that actually throws exception."

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6228:
URL: https://github.com/apache/netbeans/pull/6228#issuecomment-1642311522

   tested:
    - fresh config
    - open maven-indexer parent https://github.com/apache/maven-indexer/
    - open all sub modules
    - open a pom, let nb index local repo, allow remote indexing
    - check that the basics work, add dependency, version completion, etc
    - check for no exceptions
   ```
   INFO [org.netbeans.modules.maven.indexer.NexusRepositoryIndexerImpl]: Indexing [scan] of local took 111.81s.
   INFO [org.netbeans.modules.maven.indexer.NexusRepositoryIndexerImpl]: Indexing [download, create] of central took 617.41s.
   INFO [org.netbeans.modules.maven.indexer.NexusRepositoryIndexerImpl]: Indexing [download, create] of apache.snapshots took 41.38s.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists