You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/04/23 06:31:03 UTC
[PR] [fix][ci] Don't allow merging PR without successful result [pulsar]
lhotari opened a new pull request, #22563:
URL: https://github.com/apache/pulsar/pull/22563
### Motivation
Currently it's possible to merge a PR when it hasn't been approved at all and no tests have run.
The reason for this is that the required job gets skipped in this case.
### Modifications
- Fix the rules for `Pulsar CI checks completed` build step in the workflow.
- Continue to skip the step for cancelled scheduled jobs for other repositories than apache/pulsar.
- Add some comments to explain the logic
- Explicitly require preconditions build step to succeed
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][ci] Don't allow merging PR without successful result [pulsar]
Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower merged PR #22563:
URL: https://github.com/apache/pulsar/pull/22563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org