You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "bigben0204 (via GitHub)" <gi...@apache.org> on 2023/04/21 07:17:36 UTC

[GitHub] [doris] bigben0204 commented on pull request #18725: [Feature](profile) Add a new rest api to query instance host and ip information for query profile action in branch master

bigben0204 commented on PR #18725:
URL: https://github.com/apache/doris/pull/18725#issuecomment-1517379909

   > For this result:
   > 
   > ```
   > {
   >     "msg": "success",
   >     "code": 0,
   >     "data": [
   >         {
   >             "fragment_id": "",
   >             "time": "",
   >             "instance_id": {
   >                 "": ""
   >             }
   >         }
   >     ],
   >     "count": 0
   > }
   > ```
   > 
   > Why not add all instances' info in
   > 
   > ```
   >  "instance_id": {
   >                 "": ""
   > }
   > ```
   > 
   > ?
   
   Currently contents of instance_id in fragments api is like this:
   ```json
   {
   	"msg": "success",
   	"code": 0,
   	"data": [
   		{
   			"fragment_id": "0",
   			"time": "279.929ms",
   			"instance_id": {
   				"12d2553c9c04319-8e3fde8a05913e95": "279.929ms"
   			}
   		},
   		{
   			"fragment_id": "1",
   			"time": "279.676ms",
   			"instance_id": {
   				"12d2553c9c04319-8e3fde8a05913e92": "245.873ms",
   				"12d2553c9c04319-8e3fde8a05913e93": "279.676ms",
   				"12d2553c9c04319-8e3fde8a05913e94": "261.163ms"
   			}
   		}
   	],
   	"count": 0
   }
   ```
   Host ip and port information of instances can not be easily added in. The structure of instance_id needs to be modified, which will break compatibility of the origin fragments api.
   So add a new instances api to query host ip and port information.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org