You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "rg9975 (via GitHub)" <gi...@apache.org> on 2024/07/08 21:12:12 UTC
[PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
rg9975 opened a new pull request, #9356:
URL: https://github.com/apache/cloudstack/pull/9356
### Description
This PR fixes an issue with storage volume migrations when a storage pool (source or destination) has ScopeType.HOST set. Prior to this PR, the code in StorageSystemDataMotionStrategy selected any host in the cluster if the source storage pool did not have a cluster ID, or a host in the cluster if it did. This effectively breaks ScopeType.HOST copies except when the selection resulted in the specific host the other storage pool resides on.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
### How Has This Been Tested?
Performed copies between a local KVM storage pool and a FiberChannelAdapter storage pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216873361
<b>[SF] Trillian Build Failed (tid-10779)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216909408
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2218764965
<b>[SF] Trillian test result (tid-10782)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45887 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9356-t10782-kvm-centos7.zip
Smoke tests completed. 129 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_secure_vm_migration | `Error` | 134.11 | test_vm_life_cycle.py
test_01_secure_vm_migration | `Error` | 134.11 | test_vm_life_cycle.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 239.15 | test_host_maintenance.py
test_hostha_kvm_host_fencing | `Error` | 108.47 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti merged PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2218745646
<b>[SF] Trillian test result (tid-10781)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 45159 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9356-t10781-vmware-67u3.zip
Smoke tests completed. 128 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | `Error` | 112.41 | test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup | `Error` | 45.05 | test_affinity_groups.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 46.37 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.08 | test_kubernetes_clusters.py
test_01_non_strict_host_anti_affinity | `Failure` | 148.40 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 104.23 | test_nonstrict_affinity_group.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216458737
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2219711596
> [SF] Trillian test result (tid-10782) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45887 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9356-t10782-kvm-centos7.zip Smoke tests completed. 129 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:
>
> Test Result Time (s) Test File
> test_01_secure_vm_migration `Error` 134.11 test_vm_life_cycle.py
> test_01_secure_vm_migration `Error` 134.11 test_vm_life_cycle.py
> test_02_cancel_host_maintenace_with_migration_jobs `Error` 239.15 test_host_maintenance.py
> test_hostha_kvm_host_fencing `Error` 108.47 test_hostha_kvm.py
verified locally, there are intermittent. _test_01_secure_vm_migration_ fails during tear down of VM as router is in Starting start (and unable to update the rules).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216873360
<b>[SF] Trillian Build Failed (tid-10777)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2218581194
<b>[SF] Trillian test result (tid-10780)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40435 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9356-t10780-xenserver-71.zip
Smoke tests completed. 132 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216373955
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216521262
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216787029
@rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216910529
@rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216375278
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216534593
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216769270
<b>[SF] Trillian Build Failed (tid-10775)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216404831
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9356?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.27%. Comparing base [(`f381763`)](https://app.codecov.io/gh/apache/cloudstack/commit/f381763917a73420a4dbc553ec800bf5c153da8b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e0f80db`)](https://app.codecov.io/gh/apache/cloudstack/commit/e0f80db933dee620611a240794639e6aebfadc63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (f381763) and HEAD (e0f80db). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (f381763) | HEAD (e0f80db) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.19 #9356 +/- ##
============================================
- Coverage 15.07% 4.27% -10.81%
============================================
Files 5405 365 -5040
Lines 472667 29505 -443162
Branches 60866 5161 -55705
============================================
- Hits 71269 1261 -70008
+ Misses 393468 28101 -365367
+ Partials 7930 143 -7787
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9356/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9356/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.27% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9356/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9356?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216465469
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216783033
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy on pool host when storage pool has ScopeType.HOST [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #9356:
URL: https://github.com/apache/cloudstack/pull/9356#issuecomment-2216873379
<b>[SF] Trillian Build Failed (tid-10778)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org