You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by chunhui-shi <gi...@git.apache.org> on 2017/03/08 09:31:17 UTC
[GitHub] drill pull request #776: DRILL-5165: limitRel to return correct rows for lim...
GitHub user chunhui-shi opened a pull request:
https://github.com/apache/drill/pull/776
DRILL-5165: limitRel to return correct rows for limit all case
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chunhui-shi/drill DRILL-5165
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/776.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #776
----
commit cd10342fbcf4b3779b006515fb940137d9035157
Author: chunhui-shi <cs...@maprtech.com>
Date: 2017-03-08T07:39:32Z
DRILL-5165: limitRel to return correct rows for limit all case
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #776: DRILL-5165: limitRel to return correct rows for lim...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/776#discussion_r104993761
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java ---
@@ -125,6 +125,15 @@ public void testLimitImpactExchange() throws Exception {
}
}
+ @Test
+ public void TestLimitAllOnParquet() throws Exception {
--- End diff --
Have you tried this new testcase without the change above? Will it successful or fail?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #776: DRILL-5165: limitRel to return correct rows for limit all ...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/776
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #776: DRILL-5165: limitRel to return correct rows for limit all ...
Posted by chunhui-shi <gi...@git.apache.org>.
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/776
It failed without the fix.
________________________________
From: Jinfeng Ni <no...@github.com>
Sent: Wednesday, March 8, 2017 10:56:06 AM
To: apache/drill
Cc: Chunhui Shi; Author
Subject: Re: [apache/drill] DRILL-5165: limitRel to return correct rows for limit all case (#776)
@jinfengni commented on this pull request.
________________________________
In exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java<https://github.com/apache/drill/pull/776#discussion_r104993761>:
> @@ -125,6 +125,15 @@ public void testLimitImpactExchange() throws Exception {
}
}
+ @Test
+ public void TestLimitAllOnParquet() throws Exception {
Have you tried this new testcase without the change above? Will it successful or fail?
\u2014
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://github.com/apache/drill/pull/776#pullrequestreview-25853026>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AJa9A-HOKR8SCsdrPSb_457T4kbuelsBks5rjvnGgaJpZM4MWjjd>.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #776: DRILL-5165: limitRel to return correct rows for lim...
Posted by chunhui-shi <gi...@git.apache.org>.
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/776#discussion_r105102270
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java ---
@@ -125,6 +125,15 @@ public void testLimitImpactExchange() throws Exception {
}
}
+ @Test
+ public void TestLimitAllOnParquet() throws Exception {
--- End diff --
update the tested query. I did not notice the query in unit test is slightly different than the one I used in sqlline.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #776: DRILL-5165: limitRel to return correct rows for lim...
Posted by chunhui-shi <gi...@git.apache.org>.
Github user chunhui-shi closed the pull request at:
https://github.com/apache/drill/pull/776
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---