You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Radhika PC <ra...@citrix.com> on 2013/02/18 08:31:32 UTC

Review Request: system.vm.password property is visible under global configuration when categorized as 'Secure'

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9490/
-----------------------------------------------------------

Review request for cloudstack, David Nalley, Kishan Kavala, Jessica Tomechak, Saksham Srivastava, Joe Brockmeier, and Ram Ganesh.


Description
-------

Documentation for system.vm.password.


This addresses bug cloudstack-991.


Diffs
-----

  docs/en-US/console-proxy.xml 3dd7b9f 
  docs/en-US/working-with-system-vm.xml 97459f9 

Diff: https://reviews.apache.org/r/9490/diff/


Testing
-------

Build and patch applies cleanly.


Thanks,

Radhika PC


Re: Review Request: system.vm.password property is visible under global configuration when categorized as 'Secure'

Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9490/#review16703
-----------------------------------------------------------


Below line should change:

You can view the encrypted password under the system.vm.password global parameter.

to:

You can view the decrypted password under the system.vm.password global parameter on the UI or via listConfigurations API.

- Kishan Kavala


On Feb. 18, 2013, 8:29 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9490/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 8:29 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Kishan Kavala, Jessica Tomechak, Saksham Srivastava, Joe Brockmeier, and Ram Ganesh.
> 
> 
> Description
> -------
> 
> Documentation for system.vm.password:
> 
> Added the following note under the section Working with System Virtual Machines: 
> 
> You can configure the system.vm.random.password parameter to create a random system VM password for higher security. If you set the value for system.vm.random.password to true and restart the 
> Management Server, a random password is generated and stored encrypted in the database. You can view the encrypted password under the system.vm.password global parameter.
> 
> 
> This addresses bug cloudstack-991.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/console-proxy.xml 3dd7b9f 
>   docs/en-US/working-with-system-vm.xml 97459f9 
> 
> Diff: https://reviews.apache.org/r/9490/diff/
> 
> 
> Testing
> -------
> 
> Build and patch applies cleanly.
> 
> 
> Thanks,
> 
> Radhika PC
> 
>


Re: Review Request: system.vm.password property is visible under global configuration when categorized as 'Secure'

Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9490/#review16705
-----------------------------------------------------------

Ship it!


Ship It!

- Kishan Kavala


On Feb. 18, 2013, 9:38 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9490/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 9:38 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Kishan Kavala, Jessica Tomechak, Saksham Srivastava, Joe Brockmeier, and Ram Ganesh.
> 
> 
> Description
> -------
> 
> Documentation for system.vm.password:
> 
> Added the following note under the section Working with System Virtual Machines: 
> 
> You can configure the system.vm.random.password parameter to create a random system VM password for higher security. If you set the value for system.vm.random.password to true and restart the 
> Management Server, a random password is generated and stored encrypted in the database. You can view the encrypted password under the system.vm.password global parameter.
> 
> 
> This addresses bug cloudstack-991.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/console-proxy.xml 3dd7b9f 
>   docs/en-US/working-with-system-vm.xml 97459f9 
> 
> Diff: https://reviews.apache.org/r/9490/diff/
> 
> 
> Testing
> -------
> 
> Build and patch applies cleanly.
> 
> 
> Thanks,
> 
> Radhika PC
> 
>


Re: Review Request: system.vm.password property is visible under global configuration when categorized as 'Secure'

Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9490/#review16707
-----------------------------------------------------------


Master commit: commit 2327831f7f2177894397dfc7265ffb4d8b77872a
4.1 commit : 05555e7417391279a2188584b187d4ba259b414a

- Kishan Kavala


On Feb. 18, 2013, 9:38 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9490/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 9:38 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Kishan Kavala, Jessica Tomechak, Saksham Srivastava, Joe Brockmeier, and Ram Ganesh.
> 
> 
> Description
> -------
> 
> Documentation for system.vm.password:
> 
> Added the following note under the section Working with System Virtual Machines: 
> 
> You can configure the system.vm.random.password parameter to create a random system VM password for higher security. If you set the value for system.vm.random.password to true and restart the 
> Management Server, a random password is generated and stored encrypted in the database. You can view the encrypted password under the system.vm.password global parameter.
> 
> 
> This addresses bug cloudstack-991.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/console-proxy.xml 3dd7b9f 
>   docs/en-US/working-with-system-vm.xml 97459f9 
> 
> Diff: https://reviews.apache.org/r/9490/diff/
> 
> 
> Testing
> -------
> 
> Build and patch applies cleanly.
> 
> 
> Thanks,
> 
> Radhika PC
> 
>


Re: Review Request: system.vm.password property is visible under global configuration when categorized as 'Secure'

Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9490/
-----------------------------------------------------------

(Updated Feb. 18, 2013, 9:38 a.m.)


Review request for cloudstack, David Nalley, Kishan Kavala, Jessica Tomechak, Saksham Srivastava, Joe Brockmeier, and Ram Ganesh.


Changes
-------

Incorporated Kishan's suggestion.


Description
-------

Documentation for system.vm.password:

Added the following note under the section Working with System Virtual Machines: 

You can configure the system.vm.random.password parameter to create a random system VM password for higher security. If you set the value for system.vm.random.password to true and restart the 
Management Server, a random password is generated and stored encrypted in the database. You can view the encrypted password under the system.vm.password global parameter.


This addresses bug cloudstack-991.


Diffs (updated)
-----

  docs/en-US/console-proxy.xml 3dd7b9f 
  docs/en-US/working-with-system-vm.xml 97459f9 

Diff: https://reviews.apache.org/r/9490/diff/


Testing
-------

Build and patch applies cleanly.


Thanks,

Radhika PC


Re: Review Request: system.vm.password property is visible under global configuration when categorized as 'Secure'

Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9490/
-----------------------------------------------------------

(Updated Feb. 18, 2013, 8:29 a.m.)


Review request for cloudstack, David Nalley, Kishan Kavala, Jessica Tomechak, Saksham Srivastava, Joe Brockmeier, and Ram Ganesh.


Description (updated)
-------

Documentation for system.vm.password:

Added the following note under the section Working with System Virtual Machines: 

You can configure the system.vm.random.password parameter to create a random system VM password for higher security. If you set the value for system.vm.random.password to true and restart the 
Management Server, a random password is generated and stored encrypted in the database. You can view the encrypted password under the system.vm.password global parameter.


This addresses bug cloudstack-991.


Diffs (updated)
-----

  docs/en-US/console-proxy.xml 3dd7b9f 
  docs/en-US/working-with-system-vm.xml 97459f9 

Diff: https://reviews.apache.org/r/9490/diff/


Testing
-------

Build and patch applies cleanly.


Thanks,

Radhika PC


Re: Review Request: system.vm.password property is visible under global configuration when categorized as 'Secure'

Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9490/
-----------------------------------------------------------

(Updated Feb. 18, 2013, 8:20 a.m.)


Review request for cloudstack, David Nalley, Kishan Kavala, Jessica Tomechak, Saksham Srivastava, Joe Brockmeier, and Ram Ganesh.


Changes
-------

Updated the diff. Fixed the typo.


Description
-------

Documentation for system.vm.password:

Added the following note under the section Working with System Virtual Machines: 

You can configure the systm.vm.random.password parameter to create a random system VM password for higher security. If you set the value for systm.vm.random.password to true and restart the 
Management Server, a random password is generated and stored encrypted in the database. You can view the encrypted password under the system.vm.password global parameter.


This addresses bug cloudstack-991.


Diffs (updated)
-----

  docs/en-US/console-proxy.xml 3dd7b9f 
  docs/en-US/working-with-system-vm.xml 97459f9 

Diff: https://reviews.apache.org/r/9490/diff/


Testing
-------

Build and patch applies cleanly.


Thanks,

Radhika PC


Re: Review Request: system.vm.password property is visible under global configuration when categorized as 'Secure'

Posted by Radhika PC <ra...@citrix.com>.

> On Feb. 18, 2013, 8:12 a.m., Ram Ganesh wrote:
> > docs/en-US/working-with-system-vm.xml, line 32
> > <https://reviews.apache.org/r/9490/diff/2/?file=259460#file259460line32>
> >
> >     the parameter is system.vm.random.parameter. 'e' in the system is missing in your changes.

fixed all the typos.


- Radhika


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9490/#review16701
-----------------------------------------------------------


On Feb. 18, 2013, 8:29 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9490/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 8:29 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Kishan Kavala, Jessica Tomechak, Saksham Srivastava, Joe Brockmeier, and Ram Ganesh.
> 
> 
> Description
> -------
> 
> Documentation for system.vm.password:
> 
> Added the following note under the section Working with System Virtual Machines: 
> 
> You can configure the system.vm.random.password parameter to create a random system VM password for higher security. If you set the value for system.vm.random.password to true and restart the 
> Management Server, a random password is generated and stored encrypted in the database. You can view the encrypted password under the system.vm.password global parameter.
> 
> 
> This addresses bug cloudstack-991.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/console-proxy.xml 3dd7b9f 
>   docs/en-US/working-with-system-vm.xml 97459f9 
> 
> Diff: https://reviews.apache.org/r/9490/diff/
> 
> 
> Testing
> -------
> 
> Build and patch applies cleanly.
> 
> 
> Thanks,
> 
> Radhika PC
> 
>


Re: Review Request: system.vm.password property is visible under global configuration when categorized as 'Secure'

Posted by Ram Ganesh <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9490/#review16701
-----------------------------------------------------------



docs/en-US/working-with-system-vm.xml
<https://reviews.apache.org/r/9490/#comment35426>

    the parameter is system.vm.random.parameter. 'e' in the system is missing in your changes.


- Ram Ganesh


On Feb. 18, 2013, 8:05 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9490/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 8:05 a.m.)
> 
> 
> Review request for cloudstack, David Nalley, Kishan Kavala, Jessica Tomechak, Saksham Srivastava, Joe Brockmeier, and Ram Ganesh.
> 
> 
> Description
> -------
> 
> Documentation for system.vm.password:
> 
> Added the following note under the section Working with System Virtual Machines: 
> 
> You can configure the systm.vm.random.password parameter to create a random system VM password for higher security. If you set the value for systm.vm.random.password to true and restart the 
> Management Server, a random password is generated and stored encrypted in the database. You can view the encrypted password under the system.vm.password global parameter.
> 
> 
> This addresses bug cloudstack-991.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/console-proxy.xml 3dd7b9f 
>   docs/en-US/working-with-system-vm.xml 97459f9 
> 
> Diff: https://reviews.apache.org/r/9490/diff/
> 
> 
> Testing
> -------
> 
> Build and patch applies cleanly.
> 
> 
> Thanks,
> 
> Radhika PC
> 
>


Re: Review Request: system.vm.password property is visible under global configuration when categorized as 'Secure'

Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9490/
-----------------------------------------------------------

(Updated Feb. 18, 2013, 8:05 a.m.)


Review request for cloudstack, David Nalley, Kishan Kavala, Jessica Tomechak, Saksham Srivastava, Joe Brockmeier, and Ram Ganesh.


Description (updated)
-------

Documentation for system.vm.password:

Added the following note under the section Working with System Virtual Machines: 

You can configure the systm.vm.random.password parameter to create a random system VM password for higher security. If you set the value for systm.vm.random.password to true and restart the 
Management Server, a random password is generated and stored encrypted in the database. You can view the encrypted password under the system.vm.password global parameter.


This addresses bug cloudstack-991.


Diffs
-----

  docs/en-US/console-proxy.xml 3dd7b9f 
  docs/en-US/working-with-system-vm.xml 97459f9 

Diff: https://reviews.apache.org/r/9490/diff/


Testing
-------

Build and patch applies cleanly.


Thanks,

Radhika PC


Re: Review Request: system.vm.password property is visible under global configuration when categorized as 'Secure'

Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9490/
-----------------------------------------------------------

(Updated Feb. 18, 2013, 7:38 a.m.)


Review request for cloudstack, David Nalley, Kishan Kavala, Jessica Tomechak, Saksham Srivastava, Joe Brockmeier, and Ram Ganesh.


Changes
-------

copy edited.


Description
-------

Documentation for system.vm.password.


This addresses bug cloudstack-991.


Diffs (updated)
-----

  docs/en-US/console-proxy.xml 3dd7b9f 
  docs/en-US/working-with-system-vm.xml 97459f9 

Diff: https://reviews.apache.org/r/9490/diff/


Testing
-------

Build and patch applies cleanly.


Thanks,

Radhika PC