You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Peter Bacsko (Jira)" <ji...@apache.org> on 2023/11/19 04:46:00 UTC
[jira] [Updated] (YUNIKORN-2161) Metrics code cleanup
[ https://issues.apache.org/jira/browse/YUNIKORN-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Bacsko updated YUNIKORN-2161:
-----------------------------------
Description:
There are unused methods in the metrics subsystem:
AddQueuePendingResourceMetrics()
AddQueuePreemptingResourceMetrics()
AddQueueAllocatedResourceMetrics()
(there might be others)
The production code does not call these methods and there are no unit tests either.
We can also consider removing the interfaces. Right now there is just one implementation for everything (CoreQueueMetrics, CoreSchedulerMetrics, GoRuntimeMetrics). We don't need to mock metrics because it's very lightweight, resetting the state is trivial.
was:
There are unused methods in the metrics subsystem:
AddQueuePendingResourceMetrics()
AddQueuePreemptingResourceMetrics()
AddQueueAllocatedResourceMetrics()
(there might be others)
The production code does not call these methods and there are no unit tests either.
We can also consider removing the interfaces. Right now there is just one implementation for everything (CoreQueueMetrics, CoreSchedulerMetrics, GoRuntimeMetrics). We don't need to mock metrics because it's very lightweight, restoring the state is trivial.
> Metrics code cleanup
> --------------------
>
> Key: YUNIKORN-2161
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2161
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - scheduler
> Reporter: Peter Bacsko
> Priority: Minor
>
> There are unused methods in the metrics subsystem:
> AddQueuePendingResourceMetrics()
> AddQueuePreemptingResourceMetrics()
> AddQueueAllocatedResourceMetrics()
> (there might be others)
> The production code does not call these methods and there are no unit tests either.
> We can also consider removing the interfaces. Right now there is just one implementation for everything (CoreQueueMetrics, CoreSchedulerMetrics, GoRuntimeMetrics). We don't need to mock metrics because it's very lightweight, resetting the state is trivial.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org