[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8925: Add release refinements from 0.35.2 release

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #8925: Add release refinements from 0.35.2 release
URL: https://github.com/apache/incubator-superset/pull/8925#discussion_r363208283
 
 

 ##########
 File path: RELEASING/Dockerfile.from_local_tarball
 ##########
 @@ -56,7 +56,6 @@ RUN npm ci \
 
 WORKDIR /home/superset/apache-superset-incubating-$VERSION
 RUN pip install --upgrade setuptools pip \
-    && pip install -r requirements.txt \
 
 Review comment:
   Not a simple issue. I'm all for pinned dependencies, but @villebro has a point here, since users will be using `pip install apache-superset`. Yet a good deployment should always include a requirements.txt to pin the dependencies. This docker serves has a quick test to catch immediate issues with the release prior to pushing to Apache.
   
   So I think it makes sense not to pin here, it's a plus for us to early catch dependency problems. A nightly build to test possible problems is a plus also.
   
   Finally being too restrictive on `setup.py` can trigger hard to solve issues, for example not allowing user's to bump dependencies that have problems on specific platforms, etc

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org