[GitHub] nifi pull request #1953: NIFI-4130 Add lookup controller service in Transfor...

[bdesert <gi...@git.apache.org>]

Github user bdesert commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1953#discussion_r233016908
  
    --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformXml.java ---
    @@ -82,12 +94,32 @@
     
         public static final PropertyDescriptor XSLT_FILE_NAME = new PropertyDescriptor.Builder()
                 .name("XSLT file name")
    -            .description("Provides the name (including full path) of the XSLT file to apply to the flowfile XML content.")
    -            .required(true)
    +            .description("Provides the name (including full path) of the XSLT file to apply to the flowfile XML content."
    +                    + "One of the XSLT file name and XSLT controller properties must be defined.")
    +            .required(false)
                 .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
                 .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
                 .build();
     
    +    public static final PropertyDescriptor XSLT_CONTROLLER = new PropertyDescriptor.Builder()
    +            .name("xslt-controller")
    +            .displayName("XSLT controller")
    --- End diff --
    
    "XSLT Lookup" Would be more readable. 
    Description: "Lookup controller used to store..."
    And: XSLT_CONTROLLER_KEY: "XSLT Lookup Key" (description looks fine)


---