You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/01/25 19:53:12 UTC
[GitHub] [incubator-pinot] jihaozh opened a new pull request #6486: [TE] migrate PQL queries to standard SQL
jihaozh opened a new pull request #6486:
URL: https://github.com/apache/incubator-pinot/pull/6486
This PR changes the query to Pinot to standard SQL because Pinot is adopting standard SQL syntax and semantics for querying Pinot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #6486: [TE] migrate PQL queries to standard SQL
Posted by GitBox <gi...@apache.org>.
akshayrai commented on a change in pull request #6486:
URL: https://github.com/apache/incubator-pinot/pull/6486#discussion_r564109718
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datasource/pinot/SqlUtils.java
##########
@@ -393,7 +398,7 @@ static String quote(String value) {
String quoteChar = "";
if (!StringUtils.isNumeric(value)) {
quoteChar = "\"";
- if (value.contains(quoteChar)) {
+ if (value.contains(quoteChar) || StringUtils.isEmpty(value)) {
Review comment:
StringUtils.isEmpty also checks for null. Better to run this check first `StringUtils.isEmpty(value) || value.contains(quoteChar)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh merged pull request #6486: [TE] migrate PQL queries to standard SQL
Posted by GitBox <gi...@apache.org>.
jihaozh merged pull request #6486:
URL: https://github.com/apache/incubator-pinot/pull/6486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #6486: [TE] migrate PQL queries to standard SQL
Posted by GitBox <gi...@apache.org>.
akshayrai commented on a change in pull request #6486:
URL: https://github.com/apache/incubator-pinot/pull/6486#discussion_r564109718
##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datasource/pinot/SqlUtils.java
##########
@@ -393,7 +398,7 @@ static String quote(String value) {
String quoteChar = "";
if (!StringUtils.isNumeric(value)) {
quoteChar = "\"";
- if (value.contains(quoteChar)) {
+ if (value.contains(quoteChar) || StringUtils.isEmpty(value)) {
Review comment:
StringUtils.isEmpty also checks for null. Better to run this check first `StringUtils.isEmpty(value) || value.contains(quoteChar)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org