You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/04/05 21:59:22 UTC

[GitHub] [iceberg] aokolnychyi opened a new pull request #2416: Spark: Abort changes in migrate action only if staging was successful

aokolnychyi opened a new pull request #2416:
URL: https://github.com/apache/iceberg/pull/2416


   This PR makes sure we don't call `abortStagedChanges` if `stagedTable` is null.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2416: Spark: Abort changes in migrate action only if staging was successful

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #2416:
URL: https://github.com/apache/iceberg/pull/2416#discussion_r608248535



##########
File path: spark3-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java
##########
@@ -99,6 +100,21 @@ public void testMigrateWithOptions() throws IOException {
     sql("DROP TABLE %s", tableName + "_BACKUP_");
   }
 
+  @Test
+  public void testMigrateWithInvalidMetricsConfig() throws IOException {

Review comment:
       This test would previously succeed too. It is kind of related to the change to ensure we never fail with a weird exception if the staging step fails. We are fine for now. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] aokolnychyi merged pull request #2416: Spark: Abort changes in migrate action only if staging was successful

Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #2416:
URL: https://github.com/apache/iceberg/pull/2416


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #2416: Spark: Abort changes in migrate action only if staging was successful

Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on a change in pull request #2416:
URL: https://github.com/apache/iceberg/pull/2416#discussion_r607366764



##########
File path: spark3-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java
##########
@@ -99,6 +100,21 @@ public void testMigrateWithOptions() throws IOException {
     sql("DROP TABLE %s", tableName + "_BACKUP_");
   }
 
+  @Test
+  public void testMigrateWithInvalidMetricsConfig() throws IOException {

Review comment:
       I don't think this is related?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] aokolnychyi commented on pull request #2416: Spark: Abort changes in migrate action only if staging was successful

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2416:
URL: https://github.com/apache/iceberg/pull/2416#issuecomment-813674899


   @RussellSpitzer @rdblue @shardulm94, could you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org