[GitHub] [incubator-druid] himanshug commented on a change in pull request #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster)

[GitBox <gi...@apache.org>]

himanshug commented on a change in pull request #6988: [Improvement] historical fast restart by lazy load columns metadata(20X faster)
URL: https://github.com/apache/incubator-druid/pull/6988#discussion_r281801476
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/segment/loading/SegmentLoaderConfig.java
 ##########
 @@ -36,6 +36,9 @@
   @NotEmpty
   private List<StorageLocationConfig> locations = null;
 
+  @JsonProperty("lazyLoadOnStart")
+  private boolean lazyLoadOnStart = false;
 
 Review comment:
   Please add documentation for this config . In the doc
   - note in what situation it might be useful to set this option to true.
   - note the catch mentioned in https://github.com/apache/incubator-druid/pull/6988#issuecomment-463528940 .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org