You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/17 16:27:10 UTC

[GitHub] apeforest commented on a change in pull request #12558: [MXNET-952] Check for correlation kernel size along with unittest

apeforest commented on a change in pull request #12558: [MXNET-952] Check for correlation kernel size along with unittest
URL: https://github.com/apache/incubator-mxnet/pull/12558#discussion_r218137843
 
 

 ##########
 File path: src/operator/correlation-inl.h
 ##########
 @@ -78,6 +78,7 @@ class CorrelationOp : public Operator {
     using namespace mshadow;
     CHECK_EQ(in_data.size(), 2U);
     CHECK_EQ(out_data.size(), 3U);
+    CHECK_NE(param_.kernel_size%2, 0) << "kernel size should be odd number";
 
 Review comment:
   nit: add space round '%'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services