You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/19 15:54:47 UTC
[GitHub] [beam] lukecwik commented on a change in pull request #12625: [BEAM-10752] Use TestPubsubSignal in PubsubToBigqueryIT
lukecwik commented on a change in pull request #12625:
URL: https://github.com/apache/beam/pull/12625#discussion_r473133184
##########
File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/PubsubToBigqueryIT.java
##########
@@ -101,8 +97,14 @@ public void testSimpleInsert() throws Exception {
BeamSqlRelUtils.toPCollection(pipeline, sqlEnv.parseQuery(insertStatement));
+ Supplier<Void> start = signal.waitForStart(Duration.standardMinutes(1));
Review comment:
In other places this was used it seemed like 5 mins was the default.
```suggestion
Supplier<Void> start = signal.waitForStart(Duration.standardMinutes(5));
```
##########
File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/PubsubToBigqueryIT.java
##########
@@ -158,8 +154,14 @@ public void testSimpleInsertFlat() throws Exception {
BeamSqlRelUtils.toPCollection(pipeline, sqlEnv.parseQuery(insertStatement));
+ Supplier<Void> start = signal.waitForStart(Duration.standardMinutes(1));
Review comment:
```suggestion
Supplier<Void> start = signal.waitForStart(Duration.standardMinutes(5));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org