You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by gi...@git.apache.org on 2017/08/18 22:19:45 UTC

[GitHub] iilyak opened a new pull request #762: Use fully qualified call to allow code upgrade

iilyak opened a new pull request #762: Use fully qualified call to allow code upgrade
URL: https://github.com/apache/couchdb/pull/762
 
 
   ## Overview
   
   `rexi_monitor:wait_monitor/1` function is called recursively. This means
   that hot code upgrade will not work when we are inside that
   function. Use fully qualified call to allow the update of a module.
   
   ## Testing recommendations
   
   1. Add `-export([wait_monitors/1]).`
   2. Run following snippet
       ```
       Self = self(), spawn(fun() -> rexi_monitor:wait_monitors(Self) end).
       code:soft_purge(rexi_monitor).
       ```
   3. Without this change the test ^^ would always return false.
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services