You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/06/19 04:36:38 UTC
[GitHub] [incubator-tubemq] dockerzhang opened a new pull request #163: [TUBEMQ-246]remove broker ip check
dockerzhang opened a new pull request #163:
URL: https://github.com/apache/incubator-tubemq/pull/163
remove broker IP check, the hostname with special meaning works fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] codecov-commenter edited a comment on pull request #163: [TUBEMQ-246] remove broker ip check
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #163:
URL: https://github.com/apache/incubator-tubemq/pull/163#issuecomment-646459242
# [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=h1) Report
> Merging [#163](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tubemq/commit/cf9a852a31c9bd0c61656c02f16bc4575a6c412f&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #163 +/- ##
===========================================
- Coverage 7.90% 7.90% -0.01%
Complexity 456 456
===========================================
Files 241 241
Lines 26836 26838 +2
Branches 4446 4446
===========================================
Hits 2122 2122
- Misses 24253 24255 +2
Partials 461 461
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../tubemq/server/common/utils/WebParameterUtils.java](https://codecov.io/gh/apache/incubator-tubemq/pull/163/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvV2ViUGFyYW1ldGVyVXRpbHMuamF2YQ==) | `3.26% <0.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/master/web/handler/WebBrokerDefConfHandler.java](https://codecov.io/gh/apache/incubator-tubemq/pull/163/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvd2ViL2hhbmRsZXIvV2ViQnJva2VyRGVmQ29uZkhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=footer). Last update [cf9a852...d565b7a](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] codecov-commenter commented on pull request #163: [TUBEMQ-246]remove broker ip check
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #163:
URL: https://github.com/apache/incubator-tubemq/pull/163#issuecomment-646459242
# [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=h1) Report
> Merging [#163](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tubemq/commit/cf9a852a31c9bd0c61656c02f16bc4575a6c412f&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #163 +/- ##
===========================================
+ Coverage 7.90% 7.93% +0.02%
Complexity 456 456
===========================================
Files 241 241
Lines 26836 26838 +2
Branches 4446 4446
===========================================
+ Hits 2122 2129 +7
+ Misses 24253 24249 -4
+ Partials 461 460 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../tubemq/server/common/utils/WebParameterUtils.java](https://codecov.io/gh/apache/incubator-tubemq/pull/163/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvV2ViUGFyYW1ldGVyVXRpbHMuamF2YQ==) | `3.26% <0.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...er/master/web/handler/WebBrokerDefConfHandler.java](https://codecov.io/gh/apache/incubator-tubemq/pull/163/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvd2ViL2hhbmRsZXIvV2ViQnJva2VyRGVmQ29uZkhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-tubemq/pull/163/diff?src=pr&el=tree#diff-dHViZW1xLWNvbm5lY3RvcnMvdHViZW1xLWNvbm5lY3Rvci1mbHVtZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZmx1bWUvc2luay90dWJlbXEvVHViZW1xU2luay5qYXZh) | `55.42% <0.00%> (+4.00%)` | `14.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=footer). Last update [cf9a852...290ac9d](https://codecov.io/gh/apache/incubator-tubemq/pull/163?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang merged pull request #163: [TUBEMQ-246] remove broker ip check
Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #163:
URL: https://github.com/apache/incubator-tubemq/pull/163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang commented on a change in pull request #163: [TUBEMQ-246] remove broker ip check
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on a change in pull request #163:
URL: https://github.com/apache/incubator-tubemq/pull/163#discussion_r442685741
##########
File path: tubemq-server/src/main/java/org/apache/tubemq/server/common/utils/WebParameterUtils.java
##########
@@ -631,8 +631,7 @@ public static String checkAndGetFilterConds(String inFilterConds,
continue;
}
String brokerIp =
- validAddressParameter("brokerIp", strBrokerIps[i],
- TBaseConstants.META_MAX_BROKER_IP_LENGTH, true, "");
+ checkParamCommonRequires("brokerIp", strBrokerIps[i], true);
Review comment:
In order to better expand, it is necessary to delete the IP value check, but users need to pay attention to the accuracy of the IP value when configuring the Broker’s IP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org