You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/02/05 21:38:46 UTC

[GitHub] [hbase] saintstack commented on a change in pull request #1127: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAccounting

saintstack commented on a change in pull request #1127: HBASE-23802 Remove unnecessary Configuration instantiation in LossyAccounting
URL: https://github.com/apache/hbase/pull/1127#discussion_r375522343
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/LossyCounting.java
 ##########
 @@ -80,9 +79,12 @@ public LossyCounting(double errorRate, String name, LossyCountingListener listen
       new ThreadFactoryBuilder().setDaemon(true).setNameFormat("lossy-count-%d").build());
   }
 
-  public LossyCounting(String name, LossyCountingListener listener) {
-    this(HBaseConfiguration.create().getDouble(HConstants.DEFAULT_LOSSY_COUNTING_ERROR_RATE, 0.02),
 
 Review comment:
   Ouch. To read a single config.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services